Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

backout_rate and try_efficiency rate scripts return incorrect values due to ActiveData API only returning 10000 rows #136

@Archaeopteryx

Description

@Archaeopteryx

The ActiveData API returns maximum 10000 rows (confirmed by ekyle) but some queries request more, e.g. 100000. That causes incorrect calculations.

E.g. the backout rate gets currently calculated by getting all push ids, generating a set from the result for deduplication (ekyle likely can explain why there are duplicates) and getting its length. So for queries over a longer time frame (e.g. since start of the year), the total push count gets capped, bloating the backout rate.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions