Allow automated disable&block action to be appealed (and handle such appeals) (#23832)

Author: diox

src/olympia/abuse/actions.py

@@ -801,8 +801,13 @@ def process_action(self, release_hold=False):
                 .order_by('-pk')
             )
             if self.previous_decisions.filter(
-                action=DECISION_ACTIONS.AMO_DISABLE_ADDON
+                action__in=(
+                    DECISION_ACTIONS.AMO_DISABLE_ADDON,
+                    DECISION_ACTIONS.AMO_BLOCK_ADDON,
+                )
             ).exists():
+                # FIXME: we should also automatically revert the block if the
+                # previous decision was AMO_BLOCK_ADDON.
                 target_versions = list(target_versions)
                 if target.status == amo.STATUS_DISABLED:
                     target.force_enable(skip_activity_log=True)

src/olympia/abuse/tests/test_actions.py

@@ -1783,14 +1783,18 @@ def test_notify_stakeholders_with_policy_texts(self):
 
 class TestContentActionBlockAddon(TestContentActionDisableAddon):
     ActionClass = ContentActionBlockAddon
-    takedown_decision_action = DECISION_ACTIONS.AMO_DISABLE_ADDON
+    takedown_decision_action = DECISION_ACTIONS.AMO_BLOCK_ADDON
 
     def setUp(self):
         super().setUp()
         self.decision.update(
             reviewer_user=self.task_user,
             metadata={ContentDecision.POLICY_DYNAMIC_VALUES: {}},
         )
+        self.past_negative_decision.update(
+            reviewer_user=self.task_user,
+            metadata={ContentDecision.POLICY_DYNAMIC_VALUES: {}},
+        )
         block = Block.objects.create(addon=self.addon, updated_by=self.task_user)
         BlockVersion.objects.create(block=block, version=self.another_version)
 

src/olympia/constants/abuse.py

@@ -37,6 +37,10 @@
         'AMO_DELETE_RATING',
         'AMO_DELETE_COLLECTION',
         'AMO_REJECT_VERSION_ADDON',
+        # Note: AMO_BLOCK_ADDON is appealable, but at the moment the blocking
+        # part can't be automatically reverted by a successful appeal and has
+        # to be done manually.
+        'AMO_BLOCK_ADDON',
     ),
 )
 DECISION_ACTIONS.add_subset(