Add PromotedGroupAdmin (#23321)

Author: chrstinalin

src/olympia/constants/permissions.py

@@ -177,6 +177,7 @@
         'discovery.add_discoveryaddon': DISCOVERY_EDIT,
         'discovery.change_discoveryaddon': DISCOVERY_EDIT,
         'discovery.delete_discoveryaddon': DISCOVERY_EDIT,
+        'discovery.view_discoverypromotedgroup': DISCOVERY_EDIT,
         'files.change_file': ADMIN_ADVANCED,
         'files.change_webextpermission': ADMIN_ADVANCED,
         'files.change_filevalidation': ADMIN_ADVANCED,

src/olympia/discovery/admin.py

@@ -24,7 +24,9 @@
 from olympia.promoted.admin import (
     PromotedAddonPromotionAdminInline,
     PromotedAddonVersionInline,
+    PromotedGroupAdmin,
 )
+from olympia.promoted.models import PromotedGroup
 from olympia.shelves.admin import ShelfAdmin
 from olympia.shelves.models import Shelf
 
@@ -203,6 +205,11 @@ class Meta:
         proxy = True
 
 
+class DiscoveryPromotedGroup(PromotedGroup):
+    class Meta:
+        proxy = True
+
+
 DISCOVERY_ADDON_FIELDS = ['__str__', 'addon', 'guid', 'has_promotions']
 
 
@@ -244,6 +251,7 @@ def has_promotions(self, obj):
 
 
 admin.site.register(DiscoveryAddon, DiscoveryAddonAdmin)
+admin.site.register(DiscoveryPromotedGroup, PromotedGroupAdmin)
 admin.site.register(DiscoveryItem, DiscoveryItemAdmin)
 admin.site.register(PrimaryHeroImageUpload, PrimaryHeroImageAdmin)
 admin.site.register(SecondaryHeroShelf, SecondaryHeroAdmin)

src/olympia/promoted/admin.py

@@ -3,6 +3,7 @@
 from django.forms.models import modelformset_factory
 
 from olympia.addons.models import Addon
+from olympia.amo.admin import AMOModelAdmin
 from olympia.constants.promoted import PROMOTED_GROUP_CHOICES
 from olympia.hero.models import PrimaryHero
 from olympia.versions.models import Version
@@ -117,3 +118,32 @@ def has_delete_permission(self, request, obj=None):
         if shelf and shelf.enabled and qs.count() == 1:
             return False
         return super().has_delete_permission(request=request, obj=obj)
+
+
+class PromotedGroupAdmin(AMOModelAdmin):
+    model = PromotedGroup
+    list_display = [
+        'name',
+        'listed_pre_review',
+        'unlisted_pre_review',
+        'admin_review',
+        'badged',
+        'can_primary_hero',
+        'flag_for_human_review',
+        'can_be_compatible_with_all_fenix_versions',
+        'high_profile',
+        'high_profile_rating',
+        'search_ranking_bump',
+        'active',
+    ]
+    list_filter = list_display
+    search_fields = ('name',)
+
+    def has_add_permission(self, request, obj=None):
+        return False
+
+    def has_change_permission(self, request, obj=None):
+        return False
+
+    def has_delete_permission(self, request, obj=None):
+        return False

src/olympia/promoted/tests/test_admin.py

@@ -19,6 +19,49 @@
 )
 
 
+class TestDiscoveryPromotedGroupAdmin(TestCase):
+    def setUp(self):
+        self.list_url_name = 'admin:discovery_discoverypromotedgroup_changelist'
+
+    def test_can_see_in_admin_with_discovery_edit(self):
+        user = user_factory(email='someone@mozilla.com')
+        self.grant_permission(user, 'Discovery:Edit')
+        self.client.force_login(user)
+        url = reverse('admin:index')
+        response = self.client.get(url)
+        assert response.status_code == 200
+
+        # Use django's reverse, since that's what the admin will use. Using our
+        # own would fail the assertion because of the locale that gets added.
+        self.list_url = django_reverse(self.list_url_name)
+        assert self.list_url in response.content.decode('utf-8')
+
+    def test_cannot_see_in_admin_without_discovery_edit(self):
+        user = user_factory(email='someone@mozilla.com')
+        self.client.force_login(user)
+        url = reverse('admin:index')
+        response = self.client.get(url)
+        assert response.status_code == 200
+
+        self.list_url = django_reverse(self.list_url_name)
+        assert self.list_url not in response.content.decode('utf-8')
+
+    def test_can_list_with_discovery_edit(self):
+        addon_factory(name='FooBâr')
+        user = user_factory(email='someone@mozilla.com')
+        self.grant_permission(user, 'Discovery:Edit')
+        self.client.force_login(user)
+        response = self.client.get(reverse(self.list_url_name), follow=True)
+        assert response.status_code == 200
+
+    def test_cannot_list_without_discovery_edit(self):
+        addon_factory(name='FooBâr')
+        user = user_factory(email='someone@mozilla.com')
+        self.client.force_login(user)
+        response = self.client.get(reverse(self.list_url_name), follow=True)
+        assert response.status_code == 403
+
+
 class TestDiscoveryAddonAdmin(TestCase):
     def setUp(self):
         self.list_url = reverse('admin:discovery_discoveryaddon_changelist')