Separate out SQLite disk errors

Use different error type strings for DB corruption and disk full.  This
way we can track these errors differently in Sentry.

Author: bendk

components/logins/src/error.rs

@@ -181,6 +181,24 @@ impl GetErrorHandling for Error {
                 })
                 .report_error("logins-sync"),
             },
+            Error::SqlError(rusqlite::Error::SqliteFailure(err, _)) => match err.code {
+                rusqlite::ErrorCode::DatabaseCorrupt => {
+                    ErrorHandling::convert(LoginsApiError::UnexpectedLoginsApiError {
+                        reason: self.to_string(),
+                    })
+                    .report_error("logins-db-corrupt")
+                }
+                rusqlite::ErrorCode::DiskFull => {
+                    ErrorHandling::convert(LoginsApiError::UnexpectedLoginsApiError {
+                        reason: self.to_string(),
+                    })
+                    .report_error("logins-db-disk-full")
+                }
+                _ => ErrorHandling::convert(LoginsApiError::UnexpectedLoginsApiError {
+                    reason: self.to_string(),
+                })
+                .report_error("logins-unexpected"),
+            },
             // Unexpected errors that we report to Sentry.  We should watch the reports for these
             // and do one or more of these things if we see them:
             //   - Fix the underlying issue

components/places/src/error.rs

@@ -216,24 +216,36 @@ impl GetErrorHandling for Error {
                 })
                 .log_warning()
             }
-            // Can't pattern match on `err` without adding a dep on the sqlite3-sys crate,
-            // so we just use a `if` guard.
-            Error::SqlError(rusqlite::Error::SqliteFailure(err, _))
-                if err.code == rusqlite::ErrorCode::DatabaseBusy =>
-            {
-                ErrorHandling::convert(PlacesApiError::PlacesConnectionBusy {
-                    reason: self.to_string(),
-                })
-                .log_warning()
-            }
-            Error::SqlError(rusqlite::Error::SqliteFailure(err, _))
-                if err.code == rusqlite::ErrorCode::OperationInterrupted =>
-            {
-                ErrorHandling::convert(PlacesApiError::OperationInterrupted {
+            Error::SqlError(rusqlite::Error::SqliteFailure(err, _)) => match err.code {
+                rusqlite::ErrorCode::DatabaseBusy => {
+                    ErrorHandling::convert(PlacesApiError::PlacesConnectionBusy {
+                        reason: self.to_string(),
+                    })
+                    .log_warning()
+                }
+                rusqlite::ErrorCode::OperationInterrupted => {
+                    ErrorHandling::convert(PlacesApiError::OperationInterrupted {
+                        reason: self.to_string(),
+                    })
+                    .log_info()
+                }
+                rusqlite::ErrorCode::DatabaseCorrupt => {
+                    ErrorHandling::convert(PlacesApiError::UnexpectedPlacesException {
+                        reason: self.to_string(),
+                    })
+                    .report_error("places-db-corrupt")
+                }
+                rusqlite::ErrorCode::DiskFull => {
+                    ErrorHandling::convert(PlacesApiError::UnexpectedPlacesException {
+                        reason: self.to_string(),
+                    })
+                    .report_error("places-db-disk-full")
+                }
+                _ => ErrorHandling::convert(PlacesApiError::UnexpectedPlacesException {
                     reason: self.to_string(),
                 })
-                .log_info()
-            }
+                .report_error("places-unexpected"),
+            },
             Error::InterruptedError(err) => {
                 // Can't unify with the above ... :(
                 ErrorHandling::convert(PlacesApiError::OperationInterrupted {