Skip to content

Commit 82d161b

Browse files
committed
Added logins verification telemetry
1 parent 9abfb62 commit 82d161b

File tree

6 files changed

+17
-1
lines changed

6 files changed

+17
-1
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# v143.0 (In progress)
22

3+
## 🦊 What's Changed 🦊
4+
5+
### Logins
6+
- Updated logins verification telemetry so it can be used in iOS([#6832](https://github.com/mozilla/application-services/pull/6832))
7+
38
[Full Changelog](In progress)
49

510
# v142.0 (_2025-07-21_)

automation/run_ios_tests.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ if [ "$SKIP_BUILDING" != true ]; then
3333
-g Glean \
3434
-o ./megazords/ios-rust/Sources/MozillaRustComponentsWrapper/Generated/Glean \
3535
"${SOURCE_ROOT}"/components/nimbus/metrics.yaml \
36+
"${SOURCE_ROOT}"/components/logins/metrics.yaml \
3637
"${SOURCE_ROOT}"/components/sync_manager/metrics.yaml \
3738
"${SOURCE_ROOT}"/components/sync_manager/pings.yaml
3839

components/logins/android/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ apply from: "$appServicesRootDir/publish.gradle"
99
// exposed by the plugin to be available for this project.
1010
ext {
1111
gleanNamespace = "mozilla.telemetry.glean"
12+
gleanYamlFiles = ["${project.projectDir}/../metrics.yaml"]
1213
if (gradle.hasProperty("mozconfig")) {
1314
gleanPythonEnvDir = gradle.mozconfig.substs.GRADLE_GLEAN_PARSER_VENV
1415
}

megazords/ios-rust/Sources/MozillaRustComponentsWrapper/Logins/LoginsStorage.swift

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,15 @@ open class LoginsStorage {
3838
/// use in the iOS logins verification process.
3939
open func deleteUndecryptableRecordsForRemoteReplacement() throws {
4040
return try queue.sync {
41-
try self.store.deleteUndecryptableRecordsForRemoteReplacement()
41+
let result = try self.store.deleteUndecryptableRecordsForRemoteReplacement()
42+
43+
if result.localDeleted > 0 {
44+
GleanMetrics.LoginsStore.localUndecryptableDeleted.add(Int32(result.localDeleted))
45+
}
46+
47+
if result.mirrorDeleted > 0 {
48+
GleanMetrics.LoginsStore.mirrorUndecryptableDeleted.add(Int32(result.mirrorDeleted))
49+
}
4250
}
4351
}
4452

taskcluster/scripts/build-and-test-swift.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ def generate_glean_metrics(args):
135135
str,
136136
[
137137
ROOT_DIR / "components/nimbus/metrics.yaml",
138+
ROOT_DIR / "components/logins/metrics.yaml",
138139
ROOT_DIR / "components/sync_manager/metrics.yaml",
139140
ROOT_DIR / "components/sync_manager/pings.yaml",
140141
],

0 commit comments

Comments
 (0)