Refactor: remove fixed_size option from ads-client config (#6984)

Author: luc-lisi

components/ads-client/src/lib.rs

@@ -249,16 +249,9 @@ pub struct IABContent {
     pub category_ids: Vec<String>,
 }
 
-#[derive(Debug, Clone, PartialEq, uniffi::Record)]
-pub struct MozAdsSize {
-    pub width: u16,
-    pub height: u16,
-}
-
 #[derive(Debug, Clone, PartialEq, uniffi::Record)]
 pub struct MozAdsPlacementConfig {
     pub placement_id: String,
-    pub fixed_size: Option<MozAdsSize>,
     pub iab_content: Option<IABContent>,
 }
 
@@ -302,26 +295,20 @@ mod tests {
                     taxonomy: IABContentTaxonomy::IAB2_1,
                     category_ids: vec!["entertainment".to_string()],
                 }),
-                fixed_size: None,
             },
             MozAdsPlacementConfig {
                 placement_id: "example_placement_2".to_string(),
                 iab_content: Some(IABContent {
                     taxonomy: IABContentTaxonomy::IAB3_0,
                     category_ids: vec![],
                 }),
-                fixed_size: None,
             },
             MozAdsPlacementConfig {
                 placement_id: "example_placement_3".to_string(),
                 iab_content: Some(IABContent {
                     taxonomy: IABContentTaxonomy::IAB2_1,
                     category_ids: vec![],
                 }),
-                fixed_size: Some(MozAdsSize {
-                    width: 200,
-                    height: 200,
-                }),
             },
         ];
         let request = inner_component
@@ -380,26 +367,20 @@ mod tests {
                     taxonomy: IABContentTaxonomy::IAB2_1,
                     category_ids: vec!["entertainment".to_string()],
                 }),
-                fixed_size: None,
             },
             MozAdsPlacementConfig {
                 placement_id: "example_placement_2".to_string(),
                 iab_content: Some(IABContent {
                     taxonomy: IABContentTaxonomy::IAB3_0,
                     category_ids: vec![],
                 }),
-                fixed_size: None,
             },
             MozAdsPlacementConfig {
                 placement_id: "example_placement_2".to_string(),
                 iab_content: Some(IABContent {
                     taxonomy: IABContentTaxonomy::IAB2_1,
                     category_ids: vec![],
                 }),
-                fixed_size: Some(MozAdsSize {
-                    width: 200,
-                    height: 200,
-                }),
             },
         ];
         let request = inner_component.build_request_from_placement_configs(&configs);
@@ -464,10 +445,6 @@ mod tests {
                 taxonomy: IABContentTaxonomy::IAB2_1,
                 category_ids: vec![],
             }),
-            fixed_size: Some(MozAdsSize {
-                width: 200,
-                height: 200,
-            }),
         });
 
         let mut api_resp = get_example_happy_ad_response();
@@ -501,10 +478,6 @@ mod tests {
                 taxonomy: IABContentTaxonomy::IAB2_1,
                 category_ids: vec![],
             }),
-            fixed_size: Some(MozAdsSize {
-                width: 200,
-                height: 200,
-            }),
         });
 
         let placements = inner_component
@@ -533,10 +506,6 @@ mod tests {
                 taxonomy: IABContentTaxonomy::IAB2_1,
                 category_ids: vec![],
             }),
-            fixed_size: Some(MozAdsSize {
-                width: 200,
-                height: 200,
-            }),
         });
 
         let mut api_resp = get_example_happy_ad_response();

components/ads-client/src/test_utils.rs

@@ -21,15 +21,13 @@ pub fn get_example_happy_placement_config() -> Vec<MozAdsPlacementConfig> {
                 taxonomy: IABContentTaxonomy::IAB2_1,
                 category_ids: vec!["entertainment".to_string()],
             }),
-            fixed_size: None,
         },
         MozAdsPlacementConfig {
             placement_id: "example_placement_2".to_string(),
             iab_content: Some(IABContent {
                 taxonomy: IABContentTaxonomy::IAB3_0,
                 category_ids: vec![],
             }),
-            fixed_size: None,
         },
     ]
 }
@@ -86,7 +84,6 @@ pub fn get_example_happy_placements() -> HashMap<String, MozAdsPlacement> {
                     taxonomy: IABContentTaxonomy::IAB2_1,
                     category_ids: vec!["entertainment".to_string()],
                 }),
-                fixed_size: None,
             },
             content: MozAd {
                 url: Some("https://ads.fakeexample.org/example_ad_1".to_string()),
@@ -113,7 +110,6 @@ pub fn get_example_happy_placements() -> HashMap<String, MozAdsPlacement> {
                     taxonomy: IABContentTaxonomy::IAB3_0,
                     category_ids: vec![],
                 }),
-                fixed_size: None,
             },
             content: MozAd {
                 url: Some("https://ads.fakeexample.org/example_ad_2".to_string()),