Skip to content

Commit ba7b170

Browse files
committed
Update NDK to r28
1 parent abde7a6 commit ba7b170

File tree

6 files changed

+11
-8
lines changed

6 files changed

+11
-8
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
## 🦊 What's Changed 🦊
44

5+
### Android
6+
- Upgraded NDK from r27c to r28. ([#6588](https://github.com/mozilla/application-services/pull/6588))
7+
58
### Glean
69
- Updated to v63.1.0 ([#6584](https://github.com/mozilla/application-services/pull/6584))
710

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
buildscript {
44
ext.build = [
5-
ndkVersion: "27.2.12479018", // Keep it in sync in TC Dockerfile.
5+
ndkVersion: "28.0.13004108", // Keep it in sync in TC Dockerfile.
66

77
// In general, we should aim to keep these in sync with AC
88
compileSdkVersion: 35,

components/support/rc_crypto/nss/nss_build_common/src/lib.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,13 +92,13 @@ fn link_nss_libs(kind: LinkingKind) {
9292
let target_arch = env::var("CARGO_CFG_TARGET_ARCH").unwrap();
9393
if target_arch == "x86_64" && target_os == "android" {
9494
let android_home = env::var("ANDROID_HOME").expect("ANDROID_HOME not set");
95-
const ANDROID_NDK_VERSION: &str = "27.2.12479018";
95+
const ANDROID_NDK_VERSION: &str = "28.0.13004108";
9696
// One of these will exist, depending on the host platform.
9797
const DARWIN_X86_64_LIB_DIR: &str =
98-
"/toolchains/llvm/prebuilt/darwin-x86_64/lib/clang/18/lib/linux/";
98+
"/toolchains/llvm/prebuilt/darwin-x86_64/lib/clang/19/lib/linux/";
9999
println!("cargo:rustc-link-search={android_home}/ndk/{ANDROID_NDK_VERSION}/{DARWIN_X86_64_LIB_DIR}");
100100
const LINUX_X86_64_LIB_DIR: &str =
101-
"/toolchains/llvm/prebuilt/linux-x86_64/lib/clang/18/lib/linux/";
101+
"/toolchains/llvm/prebuilt/linux-x86_64/lib/clang/19/lib/linux/";
102102
println!("cargo:rustc-link-search={android_home}/ndk/{ANDROID_NDK_VERSION}/{LINUX_X86_64_LIB_DIR}");
103103
println!("cargo:rustc-link-lib=static=clang_rt.builtins-x86_64-android");
104104
}

docs/building.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ The following instructions assume that you are building `application-services` f
108108
1. Configure the required versions of NDK
109109
`Configure menu > System Settings > Android SDK > SDK Tools > NDK > Show Package Details > NDK (Side by side)`
110110
- 27.0.12077973 (required by Fenix; note: a specific NDK version isn't configured, this maps to default [NDK version](https://developer.android.com/studio/projects/install-ndk#default-ndk-per-agp) for the [AGP version](https://searchfox.org/mozilla-central/source/mobile/android/android-components/plugins/dependencies/src/main/java/DependenciesPlugin.kt#33))
111-
- 27.2.12479018 (required by Application Services, [as configured](https://github.com/mozilla/application-services/blob/main/build.gradle#L33))
111+
- 28.0.13004108 (required by Application Services, [as configured](https://github.com/mozilla/application-services/blob/main/build.gradle#L33))
112112
1. If you are on Windows using WSL - drop to the section below, [Windows setup
113113
for Android (WSL)](building.md#windows-setup-for-android-via-wsl) before proceeding.
114114
1. Check dependencies, environment variables

docs/howtos/locally-building-jna.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Here are the steps that worked for me:
1717
for each target platform are in your `$PATH`. On my Mac with Android Studio the
1818
config was as follows:
1919
```
20-
export NDK_ROOT="$HOME/Library/Android/sdk/ndk/27.2.12479018"
20+
export NDK_ROOT="$HOME/Library/Android/sdk/ndk/28.0.13004108"
2121
export NDK_PLATFORM="$NDK_ROOT/platforms/android-25"
2222
export PATH="$PATH:$NDK_ROOT/toolchains/llvm/prebuilt/darwin-x86_64/bin"
2323
export PATH="$PATH:$NDK_ROOT/toolchains/aarch64-linux-android-4.9/prebuilt/darwin-x86_64/bin"

taskcluster/docker/linux/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ WORKDIR /builds/worker/
1919

2020
# Configuration
2121

22-
ENV ANDROID_BUILD_TOOLS "35.0.0"
22+
ENV ANDROID_BUILD_TOOLS "35.0.1"
2323
ENV ANDROID_TOOLS_VERSION "12700392"
2424
ENV ANDROID_PLATFORM_VERSION "35"
25-
ENV ANDROID_NDK_VERSION "27.2.12479018"
25+
ENV ANDROID_NDK_VERSION "28.0.13004108"
2626

2727
# Set up the language variables to avoid problems (we run locale-gen later).
2828
ENV LANG en_US.UTF-8

0 commit comments

Comments
 (0)