Skip to content

Commit ef07885

Browse files
committed
Remove branch build docs and issue template reference
1 parent f53b140 commit ef07885

File tree

2 files changed

+1
-15
lines changed

2 files changed

+1
-15
lines changed

.github/pull_request_template.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,9 @@
77
- [ ] **Quality**: This PR builds and tests run cleanly
88
- Note:
99
- For changes that need extra cross-platform testing, consider adding `[ci full]` to the PR title.
10-
- If this pull request includes a breaking change, consider [cutting a new release](https://github.com/mozilla/application-services/blob/main/docs/howtos/cut-a-new-release.md) after merging.
10+
- If this pull request includes a breaking change, consider [cutting a new release](https://github.com/mozilla/application-services/blob/main/docs/howtos/releases.md) after merging.
1111
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
1212
- [ ] **Changelog**: This PR includes a changelog entry in [CHANGELOG.md](../CHANGELOG.md) or an explanation of why it does not need one
1313
- Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
1414
- [ ] **Dependencies**: This PR follows our [dependency management guidelines](https://github.com/mozilla/application-services/blob/main/docs/dependency-management.md)
1515
- Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.
16-
17-
[Branch builds](https://github.com/mozilla/application-services/blob/main/docs/howtos/branch-builds.md): add `[firefox-android: branch-name]` to the PR title.

docs/howtos/branch-builds.md

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,6 @@
33
Branch builds are a way to build and test Fenix using branches from `application-services` and `firefox-android`.
44
iOS is not currently supported, although we may add it in the future (see [#4966](https://github.com/mozilla/application-services/issues/4966)).
55

6-
## Breaking changes in an application-services branch.
7-
8-
When we make breaking changes in an application-services branch, we typically make corresponding changes in an
9-
`android-components` branch. Branch builds allow combining those branches together in order to run CI tests
10-
and to produce APKs for manual testing. To trigger a branch build for this:
11-
12-
- Create the PR for the `application-services` branch you're working on
13-
- Add `[firefox-android: branch-name]` to the PR title
14-
- The branch build tasks will be listed as checks the Github PR. In particular:
15-
- `branch-build-fenix-test` and `branch-build-ac-test` will run the unit android-components/fenix unit tests
16-
- `branch-build-fenix-build` will contain the Fenix APK.
17-
186
## Application-services nightlies
197

208
When we make non-breaking changes, we typically merge them into main and let them sit there until the next release. In

0 commit comments

Comments
 (0)