Bug 1973969 - factory method for login store with nss key manager

Author: jo

CHANGELOG.md

@@ -5,6 +5,7 @@
 - expose constructors for `ManagedEncryptorDecryptor` and `NSSKeyManager`
 - change PrimaryPasswordAuthenticator callbacks to be async (a breaking change, but not yet used by anyone)
 - return Result in PrimaryPasswordAuthenticator callbacks (again a breaking change, but not yet used by anyone)
+- add factory for login store with nss key manager: `create_login_store_with_nss_keymanager` to avoid round-tripping the KeyManager trait interface through JS.
 
 # v141.0 (_2025-06-23_)
 

components/logins/src/lib.rs

@@ -55,3 +55,19 @@ pub fn create_login_store_with_static_key_manager(path: String, key: String) ->
         ManagedEncryptorDecryptor::new(Arc::new(StaticKeyManager::new(key)));
     Arc::new(LoginStore::new(path, Arc::new(encdec)).unwrap())
 }
+
+// Create a LoginStore with NSSKeyManager by passing in a db path and a PrimaryPasswordAuthenticator.
+//
+// Note this is only temporarily needed until a bug with UniFFI and JavaScript is fixed, which
+// prevents passing around traits in JS
+#[cfg(feature = "keydb")]
+#[uniffi::export]
+pub fn create_login_store_with_nss_keymanager(
+    path: String,
+    primary_password_authenticator: Arc<dyn PrimaryPasswordAuthenticator>,
+) -> Arc<LoginStore> {
+    let encdec: ManagedEncryptorDecryptor = ManagedEncryptorDecryptor::new(Arc::new(
+        NSSKeyManager::new(primary_password_authenticator),
+    ));
+    Arc::new(LoginStore::new(path, Arc::new(encdec)).unwrap())
+}

components/logins/src/logins.udl

@@ -29,7 +29,8 @@ namespace logins {
     /// ManagedEncryptorDecryptor by passing in a KeyManager
     EncryptorDecryptor create_managed_encdec(KeyManager key_manager);
 
-    /// Create a LoginStore by passing in a db path and a static key
+    /// Create a LoginStore with StaticKeyManager by passing in a db path and a
+    /// static key
     LoginStore create_login_store_with_static_key_manager(string path, string key);
 };