Skip to content

Commit 54b71a3

Browse files
committed
Pre-render locale-specific variants
There are still some places that dynamically determine the user's locale based on request headers (e.g. /api/v1/user/email), but most pages should now be prerendered in a specific locale, and the user should be redirected to those pages when they don't specify the locale in the URL. This also means that users can now be linked to specific locales. Theoretically, this should help both with (localised) search ranking, as well as with performance (which also influences at least Google's ranking). A good addition would be a language switcher, so that users who get linked to a locale that's not theirs, can still switch.
1 parent 2bfbea1 commit 54b71a3

File tree

250 files changed

+326
-214
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

250 files changed

+326
-214
lines changed

functional-tests/tests/global-teardown.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ async function deleteTestUserAccounts(browser: Browser) {
4747
name: "Delete account",
4848
});
4949
await deleteButtonConfirm.click();
50-
await page.waitForURL(`${getBaseTestEnvUrl()}/`);
50+
await page.waitForURL(`${getBaseTestEnvUrl()}/en`);
5151

5252
await page.goto(manageFxaAccountUrl!);
5353
await page.getByRole("link", { name: "Delete Account" }).click();

jest.config.cjs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,9 @@ const customJestConfig = {
121121
"react-dom/server": "react-dom/server.edge",
122122
// Force module uuid to resolve with the CJS entry point, because Jest does not support package.json.exports. See https://github.com/uuidjs/uuid/issues/451
123123
uuid: require.resolve("uuid"),
124+
// For some reason Jest isn't able to load `.storybook/preview` from `jest.setup.ts`
125+
// when running `npm test`, but this line fixes it:
126+
"^.*\\.storybook/preview$": "<rootDir>/.storybook/preview.tsx",
124127
},
125128

126129
// An array of regexp pattern strings, matched against all module paths before considered 'visible' to the module loader

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"build": "npm run build-glean && npm run build-nimbus && next build && npm run build-cronjobs",
1818
"cloudrun": "npm run db:migrate && npm start",
1919
"start": "next start",
20-
"lint": "stylelint '**/*.scss' && prettier --check './src' && eslint --max-warnings=0 . && tsc -p tsconfig.json --noEmit && npm run validate-nimbus",
20+
"lint": "stylelint '**/*.scss' && prettier --check './src' && eslint --max-warnings=0 . && next typegen && tsc -p tsconfig.json --noEmit && npm run validate-nimbus",
2121
"fix": "prettier --write './src' && eslint --fix . && stylelint --fix '**/*.scss'",
2222
"test": "npm run build-nimbus && jest \"\\.(spec|test)\\.ts\"",
2323
"test-integrations": "npm run build-nimbus && jest \"\\.integration\\.ts\" --coverage=false --runInBand",

src/app/(proper_react)/layout.tsx

Lines changed: 0 additions & 42 deletions
This file was deleted.

src/app/(proper_react)/(redesign)/(authenticated)/admin/announcements/AnnouncementsAdmin.module.scss renamed to src/app/[locale]/(redesign)/(authenticated)/admin/announcements/AnnouncementsAdmin.module.scss

File renamed without changes.

src/app/(proper_react)/(redesign)/(authenticated)/admin/announcements/AnnouncementsAdmin.tsx renamed to src/app/[locale]/(redesign)/(authenticated)/admin/announcements/AnnouncementsAdmin.tsx

File renamed without changes.

src/app/(proper_react)/(redesign)/(authenticated)/admin/announcements/AnnouncementsModal.module.scss renamed to src/app/[locale]/(redesign)/(authenticated)/admin/announcements/AnnouncementsModal.module.scss

File renamed without changes.

src/app/(proper_react)/(redesign)/(authenticated)/admin/announcements/AnnouncementsModal.tsx renamed to src/app/[locale]/(redesign)/(authenticated)/admin/announcements/AnnouncementsModal.tsx

File renamed without changes.

src/app/(proper_react)/(redesign)/(authenticated)/admin/announcements/DocsView.tsx renamed to src/app/[locale]/(redesign)/(authenticated)/admin/announcements/DocsView.tsx

File renamed without changes.

src/app/(proper_react)/(redesign)/(authenticated)/admin/announcements/FluentStringsView.tsx renamed to src/app/[locale]/(redesign)/(authenticated)/admin/announcements/FluentStringsView.tsx

File renamed without changes.

0 commit comments

Comments
 (0)