Skip to content

Commit 6baad36

Browse files
committed
Mark autocomplete as non-modal
Without this property, since react-aria 3.41.0, the value of the input would be cleared after every keypress. The documentation for `AriaPopoverProps` at [1] says about the `isNonModal` prop: > Whether the popover is non-modal, i.e. elements outside the popover > may be interacted with by assistive technologies. > > Most popovers should not use this option as it may negatively > impact the screen reader experience. Only use with components such > as combobox, which are designed to handle this situation carefully. Since this use case is a combobox, this should be fine. [1] https://react-spectrum.adobe.com/react-aria/usePopover.html
1 parent bfb96f9 commit 6baad36

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/app/components/client/ComboBox.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ function ComboBox(
9191
popoverRef={popoverRef}
9292
state={state}
9393
triggerRef={inputRef}
94+
isNonModal={true}
9495
placement="bottom start"
9596
>
9697
<div className={comboBoxStyles.popoverList}>

0 commit comments

Comments
 (0)