Remove unused GA4SubscriptionEvents

This essentially reverts
#5101

Except it was done manually to avoid conflicts, leaves the migration
in place and adds a new one to drop that table.

Author: Vinnl

.env

@@ -169,7 +169,5 @@ SENTRY_AUTH_TOKEN=
 # Whether GA4 sends data or not. NOTE: must be set in build environment.
 NEXT_PUBLIC_GA4_DEBUG_MODE=true
 
-GA4_API_SECRET=unsafe-default-secret-for-dev
-
 # Data broker removal estimates data
 DATA_BROKER_REMOVAL_ESTIMATES_DATA=[]

functional-tests/tests/general.spec.ts

@@ -14,7 +14,7 @@ import { getBaseTestEnvUrl } from "../utils/environment";
 const isLocal = process.env.E2E_TEST_ENV === "local";
 
 // extend enabled local feature flags for testing purposes
-const extraFeatureFlags: FeatureFlagName[] = ["GA4SubscriptionEvents"];
+const extraFeatureFlags: FeatureFlagName[] = [];
 test.use({ extraLocalForcedFeatureFlags: extraFeatureFlags });
 
 // General tests to confirm the E2E test setup works as expected

functional-tests/tests/subscriptions.spec.ts

@@ -7,7 +7,7 @@ import { getBaseTestEnvUrl } from "../utils/environment";
 import { FeatureFlagName } from "../../src/db/tables/featureFlags";
 
 // extend enabled local feature flags for testing purposes
-const extraFeatureFlags: FeatureFlagName[] = ["GA4SubscriptionEvents"];
+const extraFeatureFlags: FeatureFlagName[] = [];
 test.use({ extraLocalForcedFeatureFlags: extraFeatureFlags });
 
 const productPlans = ["Monitor Plus"];

src/app/(proper_react)/layout.tsx

@@ -3,7 +3,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import { ReactNode } from "react";
-import { headers, cookies } from "next/headers";
+import { headers } from "next/headers";
 import { getServerSession } from "../functions/server/getServerSession";
 import {
   getAcceptLangHeaderInServerComponents,
@@ -16,8 +16,6 @@ import { CountryCodeProvider } from "../../contextProviders/country-code";
 import { getCountryCode } from "../functions/server/getCountryCode";
 import { PageLoadEvent } from "../components/client/PageLoadEvent";
 import { PromptNoneAuth } from "../components/client/PromptNoneAuth";
-import { addClientIdForSubscriber } from "../../db/tables/google_analytics_clients";
-import { logger } from "../functions/server/logging";
 import { CookiesProvider } from "../../contextProviders/cookies";
 import { SubscriptionBillingProvider } from "../../contextProviders/subscription-billing-context";
 import { getSubscriptionBillingAmount } from "../functions/server/getPremiumSubscriptionInfo";
@@ -31,33 +29,6 @@ export default async function Layout({ children }: { children: ReactNode }) {
   const session = await getServerSession();
   const billing = getSubscriptionBillingAmount();
 
-  const cookieStore = await cookies();
-  // This expects the default Google Analytics cookie documented here: https://support.google.com/analytics/answer/11397207?hl=en
-  const gaCookie = cookieStore.get("_ga");
-
-  if (gaCookie && gaCookie.value) {
-    const [gaCookieVersion, gaCookiePath, gaCookieClientId, gaCookieTimestamp] =
-      gaCookie.value.split(".");
-    if (session?.user.subscriber?.id) {
-      try {
-        const parsedCookieTimestamp = new Date(
-          parseInt(gaCookieTimestamp) * 1000,
-        );
-        await addClientIdForSubscriber(
-          session?.user.subscriber?.id,
-          gaCookieVersion,
-          parseInt(gaCookiePath),
-          gaCookieClientId,
-          parsedCookieTimestamp,
-        );
-      } catch (e) {
-        logger.error("could_not_parse_ga_cookie_from_header", {
-          message: (e as Error).message,
-        });
-      }
-    }
-  }
-
   return (
     <L10nProvider bundleSources={l10nBundles}>
       <ReactAriaI18nProvider locale={getLocale(l10nBundles)}>

src/app/api/v1/fxa-rp-events/route.ts

@@ -25,8 +25,6 @@ import { revokeOAuthTokens } from "../../../../utils/fxa";
 import { changeSubscription } from "../../../functions/server/changeSubscription";
 import { deleteAccount } from "../../../functions/server/deleteAccount";
 import { record } from "../../../functions/server/glean";
-import { sendPingToGA } from "../../../functions/server/googleAnalytics";
-import { getEnabledFeatureFlags } from "../../../../db/tables/featureFlags";
 
 const FXA_PROFILE_CHANGE_EVENT =
   "https://schemas.accounts.firefox.com/event/profile-change";
@@ -278,10 +276,6 @@ export async function POST(request: NextRequest) {
         });
 
         try {
-          const enabledFeatureFlags = await getEnabledFeatureFlags({
-            email: subscriber.primary_email,
-          });
-
           if (
             updatedSubscriptionFromEvent.isActive &&
             updatedSubscriptionFromEvent.capabilities.includes(
@@ -362,10 +356,6 @@ export async function POST(request: NextRequest) {
                 monitorUserId: subscriber.id.toString(),
               },
             });
-
-            if (enabledFeatureFlags.includes("GA4SubscriptionEvents")) {
-              await sendPingToGA(subscriber.id, "subscribe");
-            }
           } else if (
             !updatedSubscriptionFromEvent.isActive &&
             updatedSubscriptionFromEvent.capabilities.includes(
@@ -423,10 +413,6 @@ export async function POST(request: NextRequest) {
                 monitorUserId: subscriber.id.toString(),
               },
             });
-
-            if (enabledFeatureFlags.includes("GA4SubscriptionEvents")) {
-              await sendPingToGA(subscriber.id, "unsubscribe");
-            }
           }
         } catch (e) {
           captureMessage(