Merge pull request #6161 from mozilla/mntor-5015

chore(plus): remove churn and coupon tables and types

Author: kschelonka

src/db/migrations/20251002092700_drop_coupon_subcriber_churn.js

@@ -0,0 +1,42 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+export async function up(knex) {
+  await knex.schema.dropTableIfExists("subscriber_churns");
+  await knex.schema.dropTableIfExists("subscriber_coupons");
+}
+
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+export async function down(knex) {
+  await knex.schema.createTable("subscriber_churns", function (table) {
+    table.increments("id").primary();
+    table.string("userid").unique();
+    table.string("customer").unique();
+    table.string("plan_id");
+    table.string("product_id");
+    table.string("intervl");
+    table.string("nickname");
+    table.timestamp("created");
+    table.timestamp("current_period_end");
+  });
+  await knex.schema.createTable("subscriber_coupons", (table) => {
+    table.increments("id").primary();
+    table
+      .integer("subscriber_id")
+      .references("subscribers.id")
+      .notNullable()
+      .onDelete("CASCADE")
+      .onUpdate("CASCADE");
+    table.string("coupon_code").notNullable();
+    table.timestamp("created_at").defaultTo(knex.fn.now());
+    table.unique(["subscriber_id", "coupon_code"]);
+  });
+}

src/knex-tables.d.ts

@@ -26,16 +26,6 @@ declare module "knex/types/tables" {
     updated_at: Date;
   }
 
-  interface SubscriberChurnRow {
-    userid: string;
-    customer: string;
-    nickname: string;
-    intervl: string;
-    plan_id: string;
-    product_id: string;
-    current_period_end: Date;
-  }
-
   interface OnerepScanResultDataBrokerRow extends OnerepScanResultRow {
     scan_result_status: RemovalStatus;
     broker_status: DataBrokerRemovalStatus;
@@ -213,17 +203,6 @@ declare module "knex/types/tables" {
     "id" | "created_at" | "updated_at"
   >;
 
-  interface SubscriberCouponRow {
-    id: number;
-    subscriber_id: number;
-    coupon_code: string;
-    created_at: Date;
-  }
-  type SubscriberCouponAutoInsertedColumns = Extract<
-    keyof SubscriberCouponRow,
-    "id" | "subscriber_id" | "created_at"
-  >;
-
   interface SubscriberEmailPreferencesRow {
     id: number;
     subscriber_id: number;
@@ -530,18 +509,6 @@ declare module "knex/types/tables" {
       >
     >;
 
-    subscriber_coupons: Knex.CompositeTableType<
-      SubscriberCouponRow,
-      // On inserts, auto-generated columns cannot be set, and nullable columns are optional:
-      WritableDateColumns<
-        Omit<SubscriberCouponRow, SubscriberAutoInsertedColumns>
-      >,
-      // On updates, don't allow updating the ID; all other fields are optional:
-      WritableDateColumns<Partial<Omit<SubscriberCouponRow, "id">>>
-    >;
-
-    subscriber_churns: SubscriberChurnRow;
-
     subscriber_email_preferences: Knex.CompositeTableType<
       SubscriberEmailPreferencesRow,
       // On inserts, auto-generated columns cannot be set, and nullable columns are optional: