Skip to content

Commit ca3bbf3

Browse files
authored
Add more Cirrus error logging info (#5483)
* Add cirrus logging errors * remove middleware logging * revert code change in middleware * remove logging userId * remove logging experimentId
1 parent 355dbb0 commit ca3bbf3

File tree

2 files changed

+25
-1
lines changed

2 files changed

+25
-1
lines changed

src/app/functions/server/getExperimentationId.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ export function getExperimentationId(
2828
// If the user is logged in, use the Subscriber ID.
2929
const namespace = process.env.NIMBUS_UUID_NAMESPACE;
3030
if (!namespace) {
31+
logger.error(
32+
"NIMBUS_UUID_NAMESPACE environment variable is missing. Cannot generate experimentationId.",
33+
);
3134
throw new Error(
3235
"NIMBUS_UUID_NAMESPACE not set, cannot create experimentationId",
3336
);
@@ -47,6 +50,9 @@ export function getExperimentationId(
4750
);
4851
return "guest-no-experimentation-id-set-by-monitor-middleware";
4952
}
53+
logger.info("Using experimentationId from header for guest user", {
54+
experimentationId,
55+
});
5056
return experimentationId as ExperimentationId;
5157
}
5258
}

src/app/functions/server/getExperiments.ts

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@ export async function getExperiments(params: {
5050
serverUrl.searchParams.set("nimbus_preview", "true");
5151
}
5252

53+
logger.info("Sending request to Cirrus", {
54+
serverUrl: serverUrl.toString(),
55+
previewMode: params.previewMode,
56+
});
57+
5358
const response = await fetch(serverUrl, {
5459
headers: {
5560
"Content-Type": "application/json",
@@ -65,6 +70,14 @@ export async function getExperiments(params: {
6570
}),
6671
});
6772

73+
if (!response.ok) {
74+
logger.error("Cirrus request failed", {
75+
status: response.status,
76+
url: serverUrl.toString(),
77+
});
78+
throw new Error(`Cirrus request failed: ${response.statusText}`);
79+
}
80+
6881
const json = await response.json();
6982

7083
let experimentData;
@@ -76,7 +89,12 @@ export async function getExperiments(params: {
7689

7790
return (experimentData as ExperimentData) ?? defaultExperimentData;
7891
} catch (ex) {
79-
logger.error("Could not connect to Cirrus", { serverUrl, ex });
92+
logger.error("Could not connect to Cirrus", {
93+
serverUrl,
94+
ex,
95+
flags,
96+
params,
97+
});
8098
captureException(ex);
8199
return defaultExperimentData;
82100
}

0 commit comments

Comments
 (0)