Don't inspect request headers in cron jobs

Author: Vinnl

.env

@@ -106,7 +106,7 @@ ADMINS=
 MONTHLY_CRON_ENABLED=
 
 # Functional tests
-E2E_TEST_ENV=local
+E2E_TEST_ENV="not running e2e tests"
 E2E_TEST_SECRET=test-secret
 E2E_TEST_ACCOUNT_BASE_EMAIL=test-account
 E2E_TEST_ACCOUNT_BASE_PASSWORD=test-password

functional-tests/playwright.config.ts

@@ -34,11 +34,11 @@ const webServerConfig = {
 
 // Geo locations
 export const locations = [
-  {
-    name: "US",
-    geolocation: { latitude: 40.7167, longitude: -74.0 },
-    locale: "en-US",
-  },
+  // {
+  //   name: "US",
+  //   geolocation: { latitude: 40.7167, longitude: -74.0 },
+  //   locale: "en-US",
+  // },
   {
     name: "NL",
     geolocation: { latitude: 52.370216, longitude: 4.895168 },
@@ -59,21 +59,21 @@ const baseDevices: Array<{ name: string; use: (typeof devices)[string] }> = [
       },
     },
   },
-  {
-    name: "firefox",
-    use: {
-      ...devices["Desktop Firefox"],
-      viewport: {
-        width: 1920,
-        height: 1080,
-      },
-    },
-  },
-  /* Test against mobile viewports. */
-  {
-    name: "Mobile Chrome",
-    use: devices["Pixel 5"],
-  },
+  // {
+  //   name: "firefox",
+  //   use: {
+  //     ...devices["Desktop Firefox"],
+  //     viewport: {
+  //       width: 1920,
+  //       height: 1080,
+  //     },
+  //   },
+  // },
+  // /* Test against mobile viewports. */
+  // {
+  //   name: "Mobile Chrome",
+  //   use: devices["Pixel 5"],
+  // },
 ];
 
 export const getEnabledFeatureFlags = () => {

functional-tests/tests/global-setup.ts

@@ -67,7 +67,9 @@ async function setupUserAccount(browser: Browser) {
     );
 
     // Validate user is signed in
+    console.log("SIGNED IN:", page.url());
     await page.waitForURL("**/user/**");
+    console.log("WAITED:", page.url());
 
     // Store test user session
     const storageStatePath = getTestUserSessionFilePath(project.name);
@@ -94,6 +96,9 @@ setup("Set up feature flags and user accounts", async ({ browser }) => {
   const dir = path.resolve(__dirname, "../functional-test-cache");
   fs.mkdirSync(dir, { recursive: true });
 
+  console.log("CREATING ACCOUNT", browser.browserType().name(), browser.version());
   await setupFeatureFlags();
+  console.log("SET UP FLAGS", browser.browserType().name(), browser.version());
   await setupUserAccount(browser);
+  console.log("SET UP ACCOUNT", browser.browserType().name(), browser.version());
 });

functional-tests/utils/fxa.ts

@@ -70,6 +70,7 @@ async function fillAndSubmitConfirmationCode(page: Page, email: string) {
 
 async function signUpUser(page: Page, email: string, password: string) {
   // Fill and submit sign-up form
+  console.log("SIGNING IN AS", email, password);
   await fillAndSubmitEmail(page, email);
   await fillAndSubmitPassword(page, password);
   await fillAndSubmitConfirmationCode(page, email);

package-lock.json

@@ -75,13 +75,15 @@ export default async function DashboardPage(props: Props) {
 
   const session = await getServerSession();
   if (!checkSession(session) || !session?.user?.subscriber?.fxa_uid) {
+    console.log("NO SESSION FOUND, LOGGING OUT:", { session });
     return redirect("/auth/logout");
   }
 
   const subscriber = await getSubscriberByFxaUid(
     session.user.subscriber.fxa_uid,
   );
   if (!subscriber) {
+    console.log("NO SUBSCRIBER FOUND, LOGGING OUT:", { subscriber });
     redirect("/auth/logout");
   }
 

src/app/(proper_react)/(redesign)/(authenticated)/user/(dashboard)/dashboard/[[...slug]]/page.tsx

@@ -99,6 +99,7 @@ describe("getExperiments", () => {
   });
 
   it("calls Cirrus V2 when feature flag is enabled with preview param", async () => {
+    process.env.NEXT_RUNTIME = "test";
     process.env.NIMBUS_SIDECAR_URL = "https://cirrus.example";
     getEnabledFeatureFlagsMock.mockReturnValue([
       "CirrusV2",
@@ -150,6 +151,8 @@ describe("getExperiments", () => {
         previewMode: true,
       }),
     );
+
+    delete process.env.NEXT_RUNTIME;
   });
 
   it("calls Cirrus V1 when featurn flag is disabled", async () => {
@@ -188,7 +191,8 @@ describe("getExperiments", () => {
     );
   });
 
-  it("fallsback to defaultExperimentData when not experiment data is returned by Cirrus", async () => {
+  it("fallsback to defaultExperimentData when no experiment data is returned by Cirrus", async () => {
+    process.env.NEXT_RUNTIME = "test";
     process.env.NIMBUS_SIDECAR_URL = "https://cirrus.example";
     getEnabledFeatureFlagsMock.mockReturnValue([
       "CirrusV2",
@@ -235,6 +239,7 @@ describe("getExperiments", () => {
         previewMode: true,
       }),
     );
+    delete process.env.NEXT_RUNTIME;
   });
 
   it("logs error, captures exception, and returns defaultExperimentData on error response", async () => {

src/app/functions/server/getExperiments.test.ts

@@ -59,7 +59,13 @@ export async function getExperiments(params: {
     serverUrl.pathname += "v1/features";
   }
 
-  const nextHeaders = await loadNextHeaders();
+  const nextHeaders =
+    // We also check for experiments in cron jobs, where there are
+    // no HTTP requests. Skip the headers there; we don't need to
+    // force-enable experiments in cronjobs.
+    typeof process.env.NEXT_RUNTIME === "string"
+      ? await loadNextHeaders()
+      : null;
   let previewMode = false;
   if (nextHeaders) {
     const headersList = await nextHeaders.headers();

src/app/functions/server/getExperiments.ts

@@ -92,7 +92,16 @@ export async function getEnabledFeatureFlags(
   options: { isSignedOut?: false; email: string } | { isSignedOut: true },
 ): Promise<FeatureFlagName[]> {
   // Force feature flags for E2E tests via URL query params
-  if (process.env.E2E_TEST_ENV === "local") {
+  if (
+    // Check that we're running under Next.js; in cronjobs
+    // there's no request to inspect. We're not force-enabling
+    // feature flags in that environment anyway.
+    typeof process.env.NEXT_RUNTIME === "string" &&
+    // When running end-to-end tests locally or in a PR,
+    // we can force-enable feature flags that haven't been enabled
+    // yet on stage or on prod:
+    process.env.E2E_TEST_ENV === "local"
+  ) {
     const { headers } = await import("next/headers");
     const forcedFeatureFlags = (await headers()).get("x-forced-feature-flags");