chore: Remove feature flag PrivacyProductsBundle

Author: flozia

functional-tests/fixtures/baseTest.ts

@@ -22,7 +22,6 @@ export const defaultLocalForcedFeatureFlags: FeatureFlagName[] = [
   "EditScanProfileDetails",
   "SubPlat3",
   "Announcements",
-  "PrivacyProductsBundle",
 ];
 
 const test = baseTest.extend<{

src/app/(bundle)/bundle/onboarding/BundleOnboardingView.stories.tsx

@@ -17,6 +17,5 @@ type Story = StoryObj<typeof BundleOnboardingView>;
 export const BundleOnboarding: Story = {
   args: {
     l10n: getL10n(),
-    enabledFeatureFlags: ["PrivacyProductsBundle"],
   },
 };

src/app/(bundle)/bundle/onboarding/page.tsx

@@ -11,7 +11,6 @@ import {
 } from "../../../functions/l10n/serverComponents";
 import { BundleOnboardingView } from "./BundleOnboardingView";
 import { getEnabledFeatureFlags } from "../../../../db/tables/featureFlags";
-import NotFound from "../../../not-found";
 import { getServerSession } from "../../../functions/server/getServerSession";
 
 export default async function Page() {
@@ -24,9 +23,7 @@ export default async function Page() {
         }
       : { isSignedOut: true },
   );
-  if (!enabledFeatureFlags.includes("PrivacyProductsBundle")) {
-    return NotFound();
-  }
+
   const headersList = await headers();
   const countryCode = getCountryCode(headersList);
   const l10n = getL10n(await getAcceptLangHeaderInServerComponents());

src/app/(proper_react)/(redesign)/(public)/LandingViewRedesign/LandingViewRedesign.stories.tsx

@@ -92,16 +92,6 @@ export const LandingRedesignUsScanLimit: Story = {
   },
 };
 
-export const LandingRedesignUsWithPrivacyProductBundle: Story = {
-  name: "US visitors - With Privacy Product Bundle",
-  args: {
-    eligibleForPremium: true,
-    countryCode: "us",
-    scanLimitReached: false,
-    enabledFeatureFlags: ["LandingPageRedesign", "PrivacyProductsBundle"],
-  },
-};
-
 export const LandingRedesignUsDisableOneRepScans: Story = {
   name: "US visitors - Disable OneRep Scans",
   args: {
@@ -111,13 +101,3 @@ export const LandingRedesignUsDisableOneRepScans: Story = {
     enabledFeatureFlags: ["DisableOneRepScans"],
   },
 };
-
-export const LandingRedesignUsScanLimitWithPrivacyProductBundle: Story = {
-  name: "US visitors - Scan limit reached and with Privacy Product Bundle",
-  args: {
-    eligibleForPremium: true,
-    countryCode: "us",
-    scanLimitReached: true,
-    enabledFeatureFlags: ["LandingPageRedesign", "PrivacyProductsBundle"],
-  },
-};

src/app/(proper_react)/(redesign)/(public)/LandingViewRedesign/LandingViewRedesign.test.tsx

@@ -18,8 +18,6 @@ import Meta, {
   LandingRedesignUs,
   LandingRedesignUsDisableOneRepScans,
   LandingRedesignUsScanLimit,
-  LandingRedesignUsScanLimitWithPrivacyProductBundle,
-  LandingRedesignUsWithPrivacyProductBundle,
 } from "./LandingViewRedesign.stories";
 import { useTelemetry as useTelemetryImported } from "../../../../hooks/useTelemetry";
 import { deleteAllCookies } from "../../../../functions/client/deleteAllCookies";
@@ -260,21 +258,15 @@ describe("FAQ", () => {
 
 describe("Pricing plan", () => {
   it("passes the axe accessibility test suite", async () => {
-    const ComposedLanding = composeStory(
-      LandingRedesignUsWithPrivacyProductBundle,
-      Meta,
-    );
+    const ComposedLanding = composeStory(LandingRedesignUs, Meta);
     const { container } = render(<ComposedLanding />);
     expect(await axe(container)).toHaveNoViolations();
   }, 10_000);
 
   it("can initiate sign in from the Monitor (free) pricing card", async () => {
     const user = userEvent.setup();
 
-    const ComposedDashboard = composeStory(
-      LandingRedesignUsWithPrivacyProductBundle,
-      Meta,
-    );
+    const ComposedDashboard = composeStory(LandingRedesignUs, Meta);
     render(<ComposedDashboard />);
     const freeCard = screen.getByLabelText("Monitor");
 
@@ -290,10 +282,7 @@ describe("Pricing plan", () => {
 
   it("counts the number of clicks on the pricing plan free tier button", async () => {
     const mockedRecord = useTelemetry();
-    const ComposedDashboard = composeStory(
-      LandingRedesignUsWithPrivacyProductBundle,
-      Meta,
-    );
+    const ComposedDashboard = composeStory(LandingRedesignUs, Meta);
     render(<ComposedDashboard />);
 
     const user = userEvent.setup();
@@ -314,10 +303,7 @@ describe("Pricing plan", () => {
 
   it("counts the number of clicks on the pricing plan upsell button", async () => {
     const mockedRecord = useTelemetry();
-    const ComposedDashboard = composeStory(
-      LandingRedesignUsWithPrivacyProductBundle,
-      Meta,
-    );
+    const ComposedDashboard = composeStory(LandingRedesignUs, Meta);
     render(<ComposedDashboard />);
 
     const user = userEvent.setup();
@@ -342,10 +328,7 @@ describe("Pricing plan", () => {
 
   it("counts the number of clicks on the pricing card Plus upsell button", async () => {
     const mockedRecord = useTelemetry();
-    const ComposedDashboard = composeStory(
-      LandingRedesignUsWithPrivacyProductBundle,
-      Meta,
-    );
+    const ComposedDashboard = composeStory(LandingRedesignUs, Meta);
     render(<ComposedDashboard />);
 
     const user = userEvent.setup();
@@ -370,10 +353,7 @@ describe("Pricing plan", () => {
 
   it("counts the number of clicks on the pricing card free button", async () => {
     const mockedRecord = useTelemetry();
-    const ComposedDashboard = composeStory(
-      LandingRedesignUsWithPrivacyProductBundle,
-      Meta,
-    );
+    const ComposedDashboard = composeStory(LandingRedesignUs, Meta);
     render(<ComposedDashboard />);
 
     const user = userEvent.setup();
@@ -393,10 +373,7 @@ describe("Pricing plan", () => {
   });
 
   it("confirms that the pricing card monthly upsell has the correct link for SubPlat2", async () => {
-    const ComposedStory = composeStory(
-      LandingRedesignUsWithPrivacyProductBundle,
-      Meta,
-    );
+    const ComposedStory = composeStory(LandingRedesignUs, Meta);
     render(<ComposedStory />);
 
     const plusCard = screen.getByLabelText("Monitor Plus");
@@ -415,17 +392,10 @@ describe("Pricing plan", () => {
   });
 
   it("confirms that the pricing card monthly upsell has the correct link for SubPlat3", async () => {
-    const ComposedStory = composeStory(
-      LandingRedesignUsWithPrivacyProductBundle,
-      Meta,
-    );
+    const ComposedStory = composeStory(LandingRedesignUs, Meta);
     render(
       <ComposedStory
-        enabledFeatureFlags={[
-          "LandingPageRedesign",
-          "PrivacyProductsBundle",
-          "SubPlat3",
-        ]}
+        enabledFeatureFlags={["LandingPageRedesign", "SubPlat3"]}
       />,
     );
 
@@ -492,10 +462,7 @@ describe("Scan limit reached", () => {
         })),
       }),
     );
-    const ComposedDashboard = composeStory(
-      LandingRedesignUsScanLimitWithPrivacyProductBundle,
-      Meta,
-    );
+    const ComposedDashboard = composeStory(LandingRedesignUsScanLimit, Meta);
     render(<ComposedDashboard />);
 
     await waitFor(() => {

src/db/tables/featureFlags.ts

@@ -73,7 +73,6 @@ export const featureFlagNames = [
   "EditScanProfileDetails",
   "SubPlat3",
   "Announcements",
-  "PrivacyProductsBundle",
   "DisableOneRepScans",
   "DisableLandingToDashboardRedirect",
   "Moscary",