chore(flags): remove EnableRemovalUnderMaintenanceStep flag #6183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschelonka
force-pushed
the
mntor-5029
branch
from
8cb0c38 to
f031943
Compare
kschelonka
requested review from
Vinnl,
codemist,
mansaj and
rhelmer
and removed request for
codemist
codemist
reviewed
Oct 14, 2025
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| import { redirect } from "next/navigation"; |
There was a problem hiding this comment.
I believe this page can be removed entirely?
There was a problem hiding this comment.
Everything in dashboard/fix/data-broker-profiles/removal-under-maintenance, including assets/styling.
kschelonka
force-pushed
the
mntor-5029
branch
from
6b1ad7e to
10a0ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-5029
Jira: MNTOR-3886
Description
Remove EnableRemovealUnderMaintenanceStep flag
I chose not to make breaking changes to function apis that seemed more general, although args did become unused (e.g. removing the enabledFeatureFlags argument). I can do that if preferred.
I kept the RemovalUnderMaintenance view to avoid refactoring, but it has no logic other than to redirect to eitheredit: deleted this/or/user/dashboarddepending on login state.