Skip to content

Commit 661476d

Browse files
authored
Mention resolving perfalert as WONTFIX, and don't needinfo on bugs with backlog-deferred keyword (#2545)
1 parent 95aede4 commit 661476d

File tree

2 files changed

+18
-13
lines changed

2 files changed

+18
-13
lines changed

bugbot/rules/perfalert_inactive_regression.py

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,20 @@ def get_bz_params(self, date):
4646
# performance regressions
4747
params = {
4848
"include_fields": fields,
49-
"f3": "creation_ts",
50-
"o3": "greaterthan",
51-
"v3": "2024-10-01T00:00:00Z",
52-
"f1": "regressed_by",
53-
"o1": "isnotempty",
54-
"f2": "keywords",
55-
"o2": "allwords",
56-
"v2": ["regression", "perf-alert"],
57-
"f9": "days_elapsed",
58-
"o9": "greaterthan",
59-
"v9": self.nweeks * 7,
49+
"f1": "creation_ts",
50+
"o1": "greaterthan",
51+
"v1": "2024-10-01T00:00:00Z",
52+
"f2": "regressed_by",
53+
"o2": "isnotempty",
54+
"f3": "keywords",
55+
"o3": "allwords",
56+
"v3": ["regression", "perf-alert"],
57+
"f4": "keywords",
58+
"o4": "nowords",
59+
"v4": "backlog-deferred",
60+
"f5": "days_elapsed",
61+
"o5": "greaterthan",
62+
"v5": self.nweeks * 7,
6063
"status": ["UNCONFIRMED", "NEW", "REOPENED"],
6164
"resolution": ["---"],
6265
}
@@ -89,7 +92,7 @@ def filter_bugs(self, bugs):
8992
# TODO: Attempt to needinfo the triage owner instead of ignoring the bugs
9093
# Exclude bugs whose regressor author is nobody.
9194
for bug in list(bugs.values()):
92-
if utils.is_no_assignee(bug["regressor_author_email"]):
95+
if utils.is_no_assignee(bug.get("regressor_author_email", "")):
9396
logger.warning(
9497
"Bug {}, regressor of bug {}, doesn't have an author".format(
9598
bug["regressor_id"], bug["id"]

templates/perfalert_inactive_regression_needinfo.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ It has been over {{ extra["nweeks"] * 7 }} days with no activity on this perform
22

33
:{{ nickname }}, since you are the author of the regressor, bug {{ extra[bugid]["regressor_id"] }}, which triggered this performance alert, could you please provide a progress update?
44

5-
If you need additional information/help, please needinfo the performance sheriff who filed this alert (they can be found in comment #0), or reach out in [#perftest](https://matrix.to/#/#perftest:mozilla.org), or [#perfsheriffs](https://matrix.to/#/#perfsheriffs:mozilla.org) on Element.
5+
If this regression is something that fixes a bug, changes the baseline of the regression metrics, or otherwise will not be fixed, please consider closing it as WONTFIX. [See this documentation for more information on how to handle regressions](https://firefox-source-docs.mozilla.org/testing/perfdocs/perftest-in-a-nutshell.html#help-i-have-a-regression-what-do-i-do).
6+
7+
For additional information/help, please needinfo the performance sheriff who filed this alert (they can be found in comment #0), or reach out in [#perftest](https://matrix.to/#/#perftest:mozilla.org), or [#perfsheriffs](https://matrix.to/#/#perfsheriffs:mozilla.org) on Element.
68

79
{{ documentation }}

0 commit comments

Comments
 (0)