Skip to content

Commit 8ea0058

Browse files
Don't add links to see-also that are already in url (#2719)
Co-authored-by: Suhaib Mujahid <[email protected]>
1 parent ae70593 commit 8ea0058

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

bugbot/rules/web_platform_features.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def handle_bug(
5959
data[bug_id] = {}
6060
data[bug_id]["added"] = []
6161
if features_key in self.feature_bugs:
62-
see_also_keys = url_keys(bug["see_also"])
62+
existing_keys = url_keys(bug["see_also"] + [bug["url"]])
6363

6464
feature_urls = self.feature_bugs[features_key]
6565
expected_urls = [feature_urls.feature_url]
@@ -69,7 +69,7 @@ def handle_bug(
6969
expected_urls.extend(feature_urls.spec_url)
7070
expected_keys = url_keys(expected_urls)
7171
add_urls = [
72-
url for key, url in expected_keys.items() if key not in see_also_keys
72+
url for key, url in expected_keys.items() if key not in existing_keys
7373
]
7474
if add_urls:
7575
changes["see_also"] = {"add": add_urls}
@@ -82,9 +82,8 @@ def handle_bug(
8282
return None
8383

8484
def get_bz_params(self, date) -> dict[str, str | int | list[str] | list[int]]:
85-
fields = ["id", "see_also"]
85+
fields = ["id", "url", "see_also"]
8686
self.feature_bugs = self.get_feature_bugs()
87-
print(self.feature_bugs)
8887
return {"include_fields": fields, "id": list(self.feature_bugs.keys())}
8988

9089
def get_feature_bugs(self) -> Mapping[int, FeatureUrls]:

0 commit comments

Comments
 (0)