Add a new rule for monitoring inactive telemetry alerts (#2773)

Author: gmierz

bugbot/rules/telemetryalert_inactive_regression.py

@@ -0,0 +1,150 @@
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this file,
+# You can obtain one at http://mozilla.org/MPL/2.0/.
+
+
+from libmozdata.bugzilla import BugzillaUser
+
+from bugbot.bzcleaner import BzCleaner
+from bugbot.user_activity import UserActivity, UserStatus
+
+
+class TelemetryAlertInactiveRegression(BzCleaner):
+    def __init__(self, nweeks=1):
+        super().__init__()
+        self.nweeks = nweeks
+        self.extra_ni = {"nweeks": self.nweeks}
+
+    def description(self):
+        return f"Telemetry alerts with {self.nweeks} week(s) of inactivity"
+
+    def get_extra_for_needinfo_template(self):
+        return self.extra_ni
+
+    def get_extra_for_template(self):
+        return self.extra_ni
+
+    def get_bz_params(self, date):
+        start_date, _ = self.get_dates(date)
+
+        fields = [
+            "id",
+            "history",
+        ]
+
+        # Find all bugs that have a telemetry-alert keyword, have not changed in the
+        # last week, and do not have the backlog-deferred keyword set
+        params = {
+            "include_fields": fields,
+            "f3": "keywords",
+            "o3": "allwords",
+            "v3": ["telemetry-alert"],
+            "f4": "keywords",
+            "o4": "nowords",
+            "v4": "backlog-deferred",
+            "f5": "days_elapsed",
+            "o5": "greaterthan",
+            "v5": self.nweeks * 7,
+            "status": ["UNCONFIRMED", "NEW", "REOPENED"],
+            "resolution": ["---"],
+        }
+
+        return params
+
+    def get_probe_owner(self, bug_history):
+        probe_owner = ""
+
+        for change in bug_history:
+            # Skip history changes when they are not from the intermittent bug filer
+            # since it's responsible for adding the first needinfo for the probe owner
+            if change["who"] != "[email protected]":
+                continue
+
+            # Use the CC field entry to find the email of the person that should
+            # be needinfo'ed so we don't need to parse it from the needinfo change
+            needinfo_found = False
+            for specific_change in change["changes"]:
+                if (
+                    specific_change["field_name"] == "flagtypes.name"
+                    and "needinfo" in specific_change["added"]
+                ):
+                    needinfo_found = True
+                elif specific_change["field_name"] == "cc":
+                    probe_owner = specific_change["added"]
+
+            if needinfo_found:
+                break
+
+        return probe_owner
+
+    def handle_bug(self, bug, data):
+        probe_owner = self.get_probe_owner(bug["history"])
+        if not probe_owner:
+            # Could not find a probe owner for some reason
+            return
+
+        data[str(bug["id"])] = {"probe_owner": probe_owner}
+
+        return bug
+
+    def get_needinfo_nicks(self, bugs):
+        def _user_handler(user, data):
+            data[user["name"]] = user["nick"]
+
+        authors_to_ni = set()
+        for bug_info in bugs.values():
+            authors_to_ni.add(bug_info["probe_owner"])
+
+        if not authors_to_ni:
+            return
+
+        user_emails_to_names = {}
+        BugzillaUser(
+            user_names=list(authors_to_ni),
+            include_fields=["nick", "name"],
+            user_handler=_user_handler,
+            user_data=user_emails_to_names,
+        ).wait()
+
+        for bug_info in bugs.values():
+            bug_info["nickname"] = user_emails_to_names[bug_info["probe_owner"]]
+
+    def filter_bugs(self, bugs):
+        # Exclude bugs where the regressor author is inactive or blocked needinfo.
+        # TODO: We can drop this when https://github.com/mozilla/bugbot/issues/1465 is implemented.
+        users_info = UserActivity(include_fields=["groups", "requests"]).check_users(
+            set(bug["probe_owner"] for bug in bugs.values()),
+            keep_active=True,
+            fetch_employee_info=True,
+        )
+
+        for bug_id, bug in list(bugs.items()):
+            user_info = users_info[bug["probe_owner"]]
+            if (
+                user_info["status"] != UserStatus.ACTIVE
+                or user_info["requests"]["needinfo"]["blocked"]
+            ):
+                del bugs[bug_id]
+
+        return bugs
+
+    def set_autofix(self, bugs):
+        for bugid, info in bugs.items():
+            self.add_auto_ni(
+                bugid,
+                {
+                    "mail": info["probe_owner"],
+                    "nickname": info["nickname"],
+                },
+            )
+
+    def get_bugs(self, *args, **kwargs):
+        bugs = super().get_bugs(*args, **kwargs)
+        self.get_needinfo_nicks(bugs)
+        self.filter_bugs(bugs)
+        self.set_autofix(bugs)
+        return bugs
+
+
+if __name__ == "__main__":
+    TelemetryAlertInactiveRegression().run()

configs/rules.json

@@ -478,6 +478,9 @@
   "perfalert_resolved_regression": {
     "additional_receivers": ["[email protected]", "[email protected]"]
   },
+  "telemetryalert_inactive_regression": {
+    "additional_receivers": ["[email protected]", "[email protected]"]
+  },
   "topcrash_notify": {
     "additional_receivers": ["rm"]
   }

scripts/cron_run_daily.sh

@@ -21,6 +21,9 @@ python -m bugbot.rules.perfalert_inactive_regression --production
 # Send an email about all performance alerts who were recently resolved
 python -m bugbot.rules.perfalert_resolved_regression --production
 
+# Try to detect potential telemetry alerts that have been inactive for too long
+python -m bugbot.rules.telemetryalert_inactive_regression --production
+
 # Update the webcompat score fields
 python -m bugbot.rules.webcompat_score --production
 

templates/telemetryalert_inactive_regression.html

@@ -0,0 +1,23 @@
+<p>
+    The following {{ plural('bug is a telemetry alert which has had', data, pword='bugs are telemetry alerts which have had') }} no activity in the last {{ extra['nweeks'] * 7 }} days:
+</p>
+<table {{ table_attrs }}>
+    <thead>
+        <tr>
+            <th>Bug</th>
+            <th>Summary</th>
+        </tr>
+    </thead>
+    <tbody>
+        {% for i, (bugid, summary) in enumerate(data) -%}
+            <tr {% if i % 2 == 0 %}bgcolor="#E0E0E0"
+            {% endif -%}
+            >
+            <td>
+                <a href="https://bugzilla.mozilla.org/show_bug.cgi?id={{ bugid }}">{{ bugid }}</a>
+            </td>
+            <td>{{ summary | e }}</td>
+        </tr>
+    {% endfor -%}
+</tbody>
+</table>

templates/telemetryalert_inactive_regression_needinfo.txt

@@ -0,0 +1,7 @@
+It has been over {{ extra["nweeks"] * 7 }} days with no activity on this telemetry alert.
+
+:{{ nickname }}, since you are the owner of the probe that alerted, could you please provide a progress update?
+
+If there are any questions about how to proceed for finding a culprit please check comment #0 for information on how to find help.
+
+{{ documentation }}