Skip to content

Commit d45fd04

Browse files
Improve CPU-based crash filtering logic (#2663)
Refines the logic to ignore signatures likely caused by a broken CPU by checking if at least 70% of crashes are from the affected CPU model, rather than any occurrence. This reduces false negatives in crash analysis.
1 parent 17ffb93 commit d45fd04

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

bugbot/crash/analyzer.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -792,11 +792,13 @@ def handler(search_resp: dict, data: list):
792792
# The crash is not new, skip it.
793793
continue
794794

795-
if any(
796-
cpu_info["term"] == "family 6 model 183 stepping 1"
795+
broken_cpu_count = sum(
796+
cpu_info["count"]
797797
for cpu_info in facets["cpu_info"]
798-
):
799-
# Ignore crashes that are likely caused by a broken CPU.
798+
if cpu_info["term"] == "family 6 model 183 stepping 1"
799+
)
800+
if broken_cpu_count / crash["count"] >= 0.7:
801+
# Ignore signatures that are likely caused by a broken CPU.
800802
continue
801803

802804
if any(

0 commit comments

Comments
 (0)