Run TSan in two passes to limit annotation scope

Pass 1 runs all tests without annotations, skipping the false-positive
tests that trigger races in CoreAudio's internal synchronization.
Pass 2 re-runs only those tests with --features tsan-annotations so
TSan can observe the happens-before relationship. This keeps annotation
scope minimal while maximizing TSan coverage on all other tests.

Author: ChunMinChang

run_sanitizers.sh

@@ -56,12 +56,36 @@ do
     # See: https://github.com/rust-lang/rust/issues/146465
     if [[ "${san}" == "thread" ]]; then
         export RUSTFLAGS="${RUSTFLAGS} -Cunsafe-allow-abi-mismatch=sanitizer"
+        # TSan false-positive tests: these trigger races in CoreAudio's
+        # internal synchronization that TSan cannot observe. They are
+        # skipped in pass 1 and re-run with annotations in pass 2.
+        tsan_false_positive_tests=(
+            "test_ops_duplex_voice_stream_set_input_processing_params"
+        )
+        tsan_skip_flags=""
+        for t in "${tsan_false_positive_tests[@]}"; do
+            tsan_skip_flags="${tsan_skip_flags} --skip ${t}"
+        done
+        export TSAN_SKIP_FLAGS="${tsan_skip_flags}"
     fi
     export CARGO_HOST_RUSTFLAGS=""
     # Set SANITIZER_BUILD so run_tests.sh can detect sanitizer mode.
     export SANITIZER_BUILD=1
     cargo_test_flags="-Z build-std --target ${TARGET}"
+    # Pass 1: Run all tests (TSan false-positive tests are skipped via
+    # TSAN_SKIP_FLAGS, picked up by run_tests.sh).
     sh run_tests.sh "${cargo_test_flags}"
+    # Pass 2 (TSan only): Re-run false-positive tests with annotations
+    # enabled so TSan can see CoreAudio's internal synchronization.
+    if [[ "${san}" == "thread" ]]; then
+        echo "\n\nRe-running TSan false-positive tests with annotations\n------------------------------"
+        cargo_test_flags_annotated="${cargo_test_flags} --features tsan-annotations"
+        for t in "${tsan_false_positive_tests[@]}"; do
+            echo "Running ${t} with tsan-annotations..."
+            cargo test --verbose --lib --tests ${cargo_test_flags_annotated} -- ${t}
+        done
+        unset TSAN_SKIP_FLAGS
+    fi
     unset RUSTFLAGS
     unset CARGO_HOST_RUSTFLAGS
     unset SANITIZER_BUILD

run_tests.sh

@@ -48,6 +48,12 @@ if [[ -n "${SANITIZER_ENABLED}" ]]; then
     # queues under sanitizers, allowing these tests to run.
     SKIP_TEST_FLAGS="--skip test_panic_"
     echo "Skipping #[should_panic] tests (incompatible with sanitizers)\n"
+    # TSan false-positive tests are skipped in the main run and re-run
+    # separately with annotations in run_sanitizers.sh.
+    if [[ -n "${TSAN_SKIP_FLAGS}" ]]; then
+        SKIP_TEST_FLAGS="${SKIP_TEST_FLAGS} ${TSAN_SKIP_FLAGS}"
+        echo "Skipping TSan false-positive tests (will re-run with annotations)\n"
+    fi
 fi
 
 # Run tests in the sub crate