Merge branch 'bookmarks/central' into enterprise-main

Author: Alexandre Lissy

.gitignore

@@ -395,6 +395,7 @@ toolkit/crashreporter/minidump-analyzer/target/
 
 # Ignore personal preferences files
 CLAUDE.local.md
+.claude/settings.local.json
 
 # Ignore .json.gz (typically profiles) in the root directory
 # lint-ignore-next-line: git-only

.hgignore

@@ -392,3 +392,4 @@ toolkit/themes/shared/design-system/node_modules/
 
 # Ignore personal preferences files
 ^CLAUDE\.local\.md
+.claude/settings.local.json

.stylelintrc.js

@@ -432,6 +432,11 @@ module.exports = {
         // into the HTML backup archive files that exist on a user's file system
         // and can be opened in any browser.
         "browser/components/backup/content/archive.css",
+        // Bug 2003877 - this is a centralization of a bunch of rules that had
+        // been spread across about:newtab and about:privatebrowsing. We'll
+        // fix these design tokens issues in a follow-up (presuming the
+        // replacement of the handoff bar doesn't land and remove this first).
+        "browser/components/search/content/contentSearchHandoffUI.css",
       ],
       rules: {
         "stylelint-plugin-mozilla/use-design-tokens": null,

AGENTS.md

@@ -9,7 +9,6 @@ The Firefox repository is very big and so it isn't advised to blindly run grep o
 ```
 searchfox-cli --define 'AudioContext::AudioContext' # get function impl
 searchfox-cli --define 'AudioSink' # get class definition
-searchfox-cli -q blob --path ipdl # search for a string, restrict on path
 searchfox-cli --id AudioSink -l 150 --cpp # search for identifier audio sink in C++ code, 150 results max
 ```
 - Use the `searchfox-cli` tool except if you suspect that you need to find information about something that has changed locally, in which case use `rg` or the usual tools, since `searchfox.org` only indexes public (merged) code

accessible/atk/DOMtoATK.h

@@ -5,7 +5,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include <glib.h>
-#include <cstdint>
 #include "mozilla/a11y/HyperTextAccessibleBase.h"
 #include "nsCharTraits.h"
 #include "nsString.h"

accessible/generic/HyperTextAccessible.cpp

@@ -309,7 +309,7 @@ void HyperTextAccessible::SetMathMLXMLRoles(AccAttributes* aAttributes) {
           if (mathMLFrame) {
             nsEmbellishData embellishData;
             mathMLFrame->GetEmbellishData(embellishData);
-            if (NS_MATHML_EMBELLISH_IS_FENCE(embellishData.flags)) {
+            if (embellishData.flags.contains(MathMLEmbellishFlag::Fence)) {
               if (!LocalPrevSibling()) {
                 aAttributes->SetAttribute(nsGkAtoms::xmlroles,
                                           nsGkAtoms::open_fence);
@@ -318,7 +318,7 @@ void HyperTextAccessible::SetMathMLXMLRoles(AccAttributes* aAttributes) {
                                           nsGkAtoms::close_fence);
               }
             }
-            if (NS_MATHML_EMBELLISH_IS_SEPARATOR(embellishData.flags)) {
+            if (embellishData.flags.contains(MathMLEmbellishFlag::Separator)) {
               aAttributes->SetAttribute(nsGkAtoms::xmlroles,
                                         nsGkAtoms::separator);
             }

accessible/mac/AccessibleWrap.mm

@@ -140,10 +140,10 @@
     doc->ProcessNewLiveRegions();
   }
 
-  if ((eventType == nsIAccessibleEvent::EVENT_TEXT_INSERTED ||
-       eventType == nsIAccessibleEvent::EVENT_TEXT_REMOVED ||
-       eventType == nsIAccessibleEvent::EVENT_NAME_CHANGE) &&
-      !aEvent->FromUserInput()) {
+  if (((eventType == nsIAccessibleEvent::EVENT_TEXT_INSERTED ||
+        eventType == nsIAccessibleEvent::EVENT_TEXT_REMOVED) &&
+       !aEvent->FromUserInput()) ||
+      eventType == nsIAccessibleEvent::EVENT_NAME_CHANGE) {
     for (LocalAccessible* container = aEvent->GetAccessible(); container;
          container = container->LocalParent()) {
       if (container->HasOwnContent() && IsLiveRegion(container->GetContent())) {

accessible/tests/browser/mac/browser_live_regions.js

@@ -177,3 +177,27 @@ addAccessibleTask(
     ok(true, "delete text leaf contents");
   }
 );
+
+/**
+ * Test live region announcements caused by clicking a button that modifies a region.
+ */
+addAccessibleTask(
+  `
+  <div id="status-container" aria-live="polite" aria-label="">
+  </div>
+
+  <button id="clickme" onClick="(function(){document.getElementById('status-container').setAttribute('aria-label', 'hello world');})()">
+    Add something!
+  </button>
+  `,
+  async (browser, accDoc) => {
+    let liveRegionChanged = waitForMacEvent(
+      "AXLiveRegionChanged",
+      "status-container"
+    );
+    const button = getNativeInterface(accDoc, "clickme");
+    button.performAction("AXPress");
+    await liveRegionChanged;
+    ok(true, "aria-label was changed, and event was fired");
+  }
+);

accessible/tests/mochitest/tree/test_tabbrowser.xhtml

@@ -156,13 +156,16 @@
             ];
           }
 
+          if (!SpecialPowers.getBoolPref("sidebar.revamp")) {
+            tabsAccTree.children.push({
+              role: ROLE_TEXT_CONTAINER,
+              children: []
+            });
+          }
+
           // NB: The (3) buttons are not visible, unless manually hovered,
           //     probably due to size reduction in this test.
           tabsAccTree.children.push(
-            {
-              role: ROLE_TEXT_CONTAINER,
-              children: []
-            },
             {
               // xul:tab ("about:license")
               role: ROLE_PAGETAB,

browser/actors/AboutNewTabChild.sys.mjs

@@ -44,7 +44,6 @@ export class AboutNewTabChild extends RemotePageChild {
 
       // This list must match any similar ones in render-activity-stream-html.js.
       const scripts = [
-        "chrome://browser/content/contentSearchHandoffUI.js",
         "chrome://browser/content/contentTheme.js",
         `chrome://global/content/vendor/react${debugString}.js`,
         `chrome://global/content/vendor/react-dom${debugString}.js`,