Skip to content

Commit 041d97e

Browse files
bug(nimbus): show review errors on screenshot descriptions (#13784)
Becuase * We caught a case where screenshot description review errors were not being displayed * The error was also being displayed inline with the field rather than below it This commit * Reorganizes the screenshot description layout for review errors to appear below fixes #13532
1 parent 4a823ad commit 041d97e

File tree

1 file changed

+18
-16
lines changed

1 file changed

+18
-16
lines changed

experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/edit_branches.html

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,24 @@ <h4>Branches</h4>
217217
{% endwith %}
218218
{% endif %}
219219
</div>
220-
<div class="col-8 d-flex align-items-end">
221-
{{ screenshot_form.description|add_error_class:"is-invalid" }}
220+
<div class="col-8">
221+
<div class=" d-flex align-items-end">
222+
{{ screenshot_form.description|add_error_class:"is-invalid" }}
223+
<button type="button"
224+
id="delete-screenshot-{{ screenshot_form.instance.id }}"
225+
class="btn btn-link ms-3 px-0"
226+
data-bs-toggle="tooltip"
227+
data-bs-placement="top"
228+
data-bs-title="Delete Screenshot"
229+
hx-post="{% url 'nimbus-ui-delete-branch-screenshot' slug=experiment.slug %}{% if request.GET.show_errors == 'true' %}?show_errors=true{% endif %}"
230+
hx-headers='{"X-CSRFToken": "{{ csrf_token }}"}'
231+
hx-vals='{"screenshot_id": {{ screenshot_form.instance.id }} }'
232+
hx-select="#branches-form"
233+
hx-target="#branches-form"
234+
hx-disabled-elt="this">
235+
<i class="fa-solid fa-trash"></i>
236+
</button>
237+
</div>
222238
{% for error in screenshot_form.description.errors %}
223239
<div class="invalid-feedback d-block">{{ error }}</div>
224240
{% endfor %}
@@ -241,20 +257,6 @@ <h4>Branches</h4>
241257
{% endfor %}
242258
{% endwith %}
243259
{% endif %}
244-
<button type="button"
245-
id="delete-screenshot-{{ screenshot_form.instance.id }}"
246-
class="btn btn-link ms-3 px-0"
247-
data-bs-toggle="tooltip"
248-
data-bs-placement="top"
249-
data-bs-title="Delete Screenshot"
250-
hx-post="{% url 'nimbus-ui-delete-branch-screenshot' slug=experiment.slug %}{% if request.GET.show_errors == 'true' %}?show_errors=true{% endif %}"
251-
hx-headers='{"X-CSRFToken": "{{ csrf_token }}"}'
252-
hx-vals='{"screenshot_id": {{ screenshot_form.instance.id }} }'
253-
hx-select="#branches-form"
254-
hx-target="#branches-form"
255-
hx-disabled-elt="this">
256-
<i class="fa-solid fa-trash"></i>
257-
</button>
258260
</div>
259261
</div>
260262
{% if screenshot_form.instance.pk and screenshot_form.instance.image %}

0 commit comments

Comments
 (0)