chore(nimbus): bump minimum version to 105

Becuase

* Remote Settings Certs were rotated and collectsion are now only readable by clients >=105
* We can bump the minimum supported version to 105
* We can remove any logic which verified versions <=105

This commit

* Bumps the minimum supported version to 105
* Removes any review logic that checked for versions <=105
* Updates tests

fixes #13267

Author: jaredlockhart

experimenter/experimenter/experiments/api/v5/serializers.py

@@ -1877,7 +1877,7 @@ def _validate_versions(self, data):
             raise serializers.ValidationError(
                 {
                     "firefox_min_version": [
-                        NimbusExperiment.ERROR_FIREFOX_VERSION_MIN_96
+                        NimbusExperiment.ERROR_FIREFOX_VERSION_MIN_SUPPORTED
                     ],
                 }
             )
@@ -1890,7 +1890,7 @@ def _validate_versions(self, data):
             raise serializers.ValidationError(
                 {
                     "firefox_min_version": [
-                        NimbusExperiment.ERROR_FIREFOX_VERSION_MIN_96
+                        NimbusExperiment.ERROR_FIREFOX_VERSION_MIN_SUPPORTED
                     ],
                 }
             )
@@ -1938,46 +1938,6 @@ def _validate_versions(self, data):
             )
         return data
 
-    def _validate_languages_versions(self, data):
-        application = data.get("application")
-        min_version = data.get("firefox_min_version", "")
-
-        if data.get("languages", []):
-            min_supported_version = (
-                NimbusConstants.LANGUAGES_APPLICATION_SUPPORTED_VERSION[application]
-            )
-            if NimbusExperiment.Version.parse(
-                min_version
-            ) < NimbusExperiment.Version.parse(min_supported_version):
-                raise serializers.ValidationError(
-                    {
-                        "languages": f"Language targeting is not \
-                            supported for this application below \
-                                version {min_supported_version}"
-                    }
-                )
-        return data
-
-    def _validate_countries_versions(self, data):
-        application = data.get("application")
-        min_version = data.get("firefox_min_version", "")
-
-        if data.get("countries", []):
-            min_supported_version = (
-                NimbusConstants.COUNTRIES_APPLICATION_SUPPORTED_VERSION[application]
-            )
-            if NimbusExperiment.Version.parse(
-                min_version
-            ) < NimbusExperiment.Version.parse(min_supported_version):
-                raise serializers.ValidationError(
-                    {
-                        "countries": f"Country targeting is \
-                            not supported for this application \
-                                below version {min_supported_version}"
-                    }
-                )
-        return data
-
     def _validate_enrollment_targeting(self, data):
         excluded_experiments = set(data.get("excluded_experiments", []))
         required_experiments = set(data.get("required_experiments", []))
@@ -2011,27 +1971,6 @@ def _validate_sticky_enrollment(self, data):
 
         return data
 
-    def _validate_rollout_version_support(self, data):
-        if not self.instance or not self.instance.is_rollout:
-            return data
-
-        min_version = NimbusExperiment.Version.parse(self.instance.firefox_min_version)
-        rollout_version_supported = NimbusExperiment.ROLLOUT_SUPPORT_VERSION.get(
-            self.instance.application
-        )
-        if (
-            rollout_version_supported is not None
-            and min_version < NimbusExperiment.Version.parse(rollout_version_supported)
-        ):
-            raise serializers.ValidationError(
-                {
-                    "is_rollout": f"Rollouts are not supported for this application \
-                                below version {rollout_version_supported}"
-                }
-            )
-
-        return data
-
     def _validate_bucket_duplicates(self, data):
         is_rollout = self.instance.is_rollout
         if not self.instance or not is_rollout:
@@ -2442,7 +2381,6 @@ def validate(self, data):
         data = self._validate_feature_configs(data)
         data = self._validate_enrollment_targeting(data)
         data = self._validate_sticky_enrollment(data)
-        data = self._validate_rollout_version_support(data)
         data = self._validate_bucket_duplicates(data)
         data = self._validate_proposed_release_date(data)
         data = self._validate_feature_value_variables(data)
@@ -2451,9 +2389,6 @@ def validate(self, data):
         if application == NimbusExperiment.Application.DESKTOP:
             data = self._validate_desktop_pref_rollouts(data)
             data = self._validate_desktop_pref_flips(data)
-        else:
-            data = self._validate_languages_versions(data)
-            data = self._validate_countries_versions(data)
         return data
 
 

experimenter/experimenter/experiments/constants.py

@@ -951,14 +951,6 @@ class FirefoxLabsGroups(models.TextChoices):
         Application.FOCUS_IOS: Version.FIREFOX_116,
     }
 
-    ROLLOUT_SUPPORT_VERSION = {
-        Application.DESKTOP: Version.FIREFOX_105,
-        Application.FENIX: Version.FIREFOX_105,
-        Application.FOCUS_ANDROID: Version.FIREFOX_105,
-        Application.IOS: Version.FIREFOX_105,
-        Application.FOCUS_IOS: Version.FIREFOX_105,
-    }
-
     LOCALIZATION_SUPPORTED_VERSION = {
         Application.DESKTOP: Version.FIREFOX_113,
     }
@@ -1053,7 +1045,7 @@ class FirefoxLabsGroups(models.TextChoices):
     ERROR_FIREFOX_VERSION_MIN = (
         "Ensure this value is less than or equal to the maximum version"
     )
-    ERROR_FIREFOX_VERSION_MIN_96 = "The minimum targetable Firefox version is 96"
+    ERROR_FIREFOX_VERSION_MIN_SUPPORTED = "The minimum targetable Firefox version is 105"
     ERROR_FIREFOX_VERSION_MAX = (
         "Ensure this value is greater than or equal to the minimum version"
     )
@@ -1125,7 +1117,7 @@ class FirefoxLabsGroups(models.TextChoices):
 
     L10N_MIN_STRING_ID_LEN = 9
 
-    MIN_REQUIRED_VERSION = Version.FIREFOX_96
+    MIN_REQUIRED_VERSION = Version.FIREFOX_105
 
     EXCLUDED_REQUIRED_MIN_VERSION = Version.FIREFOX_116
 

experimenter/experimenter/experiments/models.py

@@ -2224,9 +2224,8 @@ def get_invalid_fields_errors(self):
         serializer_data = NimbusReviewSerializer(self).data
         serializer = NimbusReviewSerializer(self, data=serializer_data)
 
-        if serializer.is_valid():
-            return {}
-        else:
+        errors = {}
+        if not serializer.is_valid():
             errors = serializer.errors
 
             if "excluded_experiments" in errors:
@@ -2239,7 +2238,7 @@ def get_invalid_fields_errors(self):
                     "required_experiments"
                 )
 
-            return errors
+        return errors
 
     def clone(self, name, user, rollout_branch_slug=None, changed_on=None):
         # Inline import to prevent circular import