fix(nimbus): fix absolute value being called on None

Author: moibra05

experimenter/experimenter/experiments/models.py

@@ -1538,7 +1538,9 @@ def format_relative_entries(self, metric_src, significance_map, reference_branch
         for i, data_point in enumerate(relative_data_list):
             lower = data_point.get("lower")
             upper = data_point.get("upper")
-            avg_rel_change = abs(data_point.get("point"))
+            avg_rel_change = (
+                abs(data_point.get("point")) if data_point.get("point") else None
+            )
             significance = significance_map.get(str(i + 1), "neutral")
             rel_entries.append(
                 {

experimenter/experimenter/nimbus_ui/templatetags/nimbus_extras.py

@@ -335,6 +335,8 @@ def format_string(value, arg):
 
 @register.filter
 def to_percentage(value, precision=None):
+    if value is None or type(value) not in [int, float]:
+        return "N/A"
     percentage_value = value * 100
 
     if precision is None:

experimenter/experimenter/nimbus_ui/tests/test_filters.py

@@ -160,6 +160,10 @@ def test_to_percentage_no_precision_specified(self):
         self.assertEqual(to_percentage(0.123), "12.3%")
         self.assertEqual(to_percentage(0.12), "12.0%")
 
+    def test_to_percentage_invalid(self):
+        self.assertEqual(to_percentage("invalid"), "N/A")
+        self.assertEqual(to_percentage(None), "N/A")
+
     def test_dict_get(self):
         sample_dict = {"key1": "value1", "key2": "value2"}
         self.assertEqual(dict_get(sample_dict, "key1"), "value1")