Skip to content

Commit a360a0a

Browse files
fix(nimbus): add FIREFOX_DESKTOP parametrize to advanced targeting test (#14987)
Because * The test_check_advanced_targeting function uses the driver fixture instead of selenium, which means it lacks the FIREFOX_DESKTOP parametrize ID that -k FIREFOX_DESKTOP filters on * This caused all 215 advanced targeting tests to be silently deselected, leaving only 7 audience targeting tests running This commit * Adds @pytest.mark.parametrize so -k FIREFOX_DESKTOP matches Fixes #14981 --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 1eb4eed commit a360a0a

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

experimenter/tests/integration/nimbus/test_desktop_targeting.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import json
2+
import uuid
23
from functools import cache
34
from pathlib import Path
45

@@ -12,8 +13,9 @@
1213
@pytest.fixture(scope="module")
1314
def base_experiment_slug():
1415
"""Create one experiment per module that gets reused for all targeting tests."""
16+
name = f"targeting-test-base-{uuid.uuid4().hex[:8]}"
1517
slug = helpers.create_basic_experiment(
16-
"targeting-test-base",
18+
name,
1719
BaseExperimentApplications.FIREFOX_DESKTOP.value,
1820
)
1921
return slug
@@ -32,9 +34,11 @@ def targeting_script():
3234
return f.read()
3335

3436

37+
@pytest.mark.parametrize("application", ["firefox-desktop"], ids=["FIREFOX_DESKTOP"])
3538
@pytest.mark.run_targeting
3639
def test_check_advanced_targeting(
3740
driver,
41+
application,
3842
base_experiment_slug,
3943
targeting_config_slug,
4044
targeting_script,

0 commit comments

Comments
 (0)