feat(nimbus): setup results page with required data (#13718)

Because

- Results page view context requires specific data to render contents 

This commit

- Passes the required context data through the view

Fixes #13682

Author: moibra05

experimenter/experimenter/experiments/models.py

@@ -1568,6 +1568,19 @@ def has_displayable_results(self):
 
         return False
 
+    @property
+    def has_exposures(self):
+        # True if there are any exposures in the results data
+        if self.results_data and "v3" in self.results_data:
+            results_data = self.results_data["v3"]
+            for window in ["overall", "weekly"]:
+                if results_data.get(window):
+                    exposure_data = results_data[window].get("exposures", {}).get("all")
+                    if exposure_data is not None:
+                        return True
+
+        return False
+
     @property
     def show_results_url(self):
         # if there are results, show them! even if the dates are wrong

experimenter/experimenter/experiments/tests/test_models.py

@@ -3259,6 +3259,22 @@ def test_has_displayable_results_true(self, results_data):
 
         self.assertTrue(experiment.has_displayable_results)
 
+    def test_has_exposures_results_true(self):
+        results_data = {"v3": {"overall": {"exposures": {"all": {}}}}}
+        experiment = NimbusExperimentFactory.create()
+        experiment.results_data = results_data
+        experiment.save()
+
+        self.assertTrue(experiment.has_exposures)
+
+    def test_has_exposures_results_false(self):
+        results_data = {"v3": {"overall": {"enrollments": {"all": {}}}}}
+        experiment = NimbusExperimentFactory.create()
+        experiment.results_data = results_data
+        experiment.save()
+
+        self.assertFalse(experiment.has_exposures)
+
     @parameterized.expand(
         [
             ({},),

experimenter/experimenter/nimbus_ui/tests/test_views.py

@@ -2988,6 +2988,102 @@ def test_render_to_response(self):
         self.assertEqual(response.context["experiment"], experiment)
         self.assertTemplateUsed(response, "nimbus_experiments/results.html")
 
+    @parameterized.expand(
+        [
+            (
+                {
+                    "v3": {
+                        "other_metrics": {"group": {"metricA": "Metric A"}},
+                        "metadata": {
+                            "metrics": {"metricA": {"friendlyName": "Friendly Metric A"}},
+                        },
+                        "overall": {
+                            "enrollments": {"all": {}},
+                            "exposures": {"all": {}},
+                        },
+                        "weekly": {
+                            "enrollments": {"all": {}},
+                            "exposures": {"all": {}},
+                        },
+                    }
+                },
+                "exposures",
+                {"metricA": "Friendly Metric A"},
+            ),
+            (
+                {
+                    "v3": {
+                        "other_metrics": {"group": {"metricA": "Metric A"}},
+                        "metadata": {
+                            "metrics": {"metricA": {"friendlyName": "Friendly Metric A"}},
+                        },
+                        "overall": {"enrollments": {"all": {}}},
+                    }
+                },
+                "enrollments",
+                {"metricA": "Friendly Metric A"},
+            ),
+        ]
+    )
+    def test_results_view_context_and_defaults(
+        self, results_data, selected_analysis_basis, default_metrics
+    ):
+        experiment = NimbusExperimentFactory.create_with_lifecycle(
+            NimbusExperimentFactory.Lifecycles.ENDING_APPROVE_APPROVE,
+        )
+
+        experiment.results_data = results_data
+        experiment.save()
+
+        response = self.client.get(
+            reverse("nimbus-ui-results", kwargs={"slug": experiment.slug}),
+        )
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(
+            response.context["results_data"], experiment.results_data.get("v3")
+        )
+        self.assertEqual(response.context["default_metrics"], default_metrics)
+        self.assertEqual(
+            response.context["selected_reference_branch"],
+            experiment.reference_branch.name,
+        )
+        self.assertEqual(response.context["selected_segment"], "all")
+        self.assertEqual(
+            response.context["selected_analysis_basis"], selected_analysis_basis
+        )
+
+    def test_results_view_query_param_overrides(self):
+        experiment = NimbusExperimentFactory.create_with_lifecycle(
+            NimbusExperimentFactory.Lifecycles.ENDING_APPROVE_APPROVE,
+        )
+
+        experiment.results_data = {
+            "v3": {
+                "other_metrics": {},
+                "metadata": {"metrics": {}},
+                "overall": {"enrollments": {"all": {}}, "exposures": {"all": {}}},
+            }
+        }
+        experiment.save()
+
+        response = self.client.get(
+            reverse(
+                "nimbus-ui-results",
+                kwargs={"slug": experiment.slug},
+                query={
+                    "reference_branch": "treatment-a",
+                    "segment": "foo",
+                    "analysis_basis": "enrollments",
+                },
+            )
+        )
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response.context["selected_reference_branch"], "treatment-a")
+        self.assertEqual(response.context["selected_segment"], "foo")
+        self.assertEqual(response.context["selected_analysis_basis"], "enrollments")
+
 
 class TestBranchScreenshotCreateView(AuthTestCase):
     def test_post_creates_screenshot(self):

experimenter/experimenter/nimbus_ui/views.py

@@ -651,6 +651,38 @@ class ApproveUpdateRolloutView(StatusUpdateView):
 class ResultsView(NimbusExperimentViewMixin, DetailView):
     template_name = "nimbus_experiments/results.html"
 
+    def get_context_data(self, **kwargs):
+        context = super().get_context_data(**kwargs)
+        experiment = self.get_object()
+
+        analysis_data = experiment.results_data.get("v3", {})
+        other_metrics = analysis_data.get("other_metrics", {})
+        metrics_metadata = analysis_data.get("metadata", {}).get("metrics", {})
+        default_metrics = {}
+
+        for value in other_metrics.values():
+            for metricKey, metricValue in value.items():
+                default_metrics[metricKey] = metrics_metadata.get(metricKey, {}).get(
+                    "friendlyName", metricValue
+                )
+
+        context["default_metrics"] = default_metrics
+
+        selected_reference_branch = self.request.GET.get(
+            "reference_branch", experiment.reference_branch.name
+        )
+        context["selected_reference_branch"] = selected_reference_branch
+
+        selected_segment = self.request.GET.get("segment", "all")
+        context["selected_segment"] = selected_segment
+        analysis_basis = self.request.GET.get(
+            "analysis_basis", "exposures" if experiment.has_exposures else "enrollments"
+        )
+        context["selected_analysis_basis"] = analysis_basis
+
+        context["results_data"] = analysis_data
+        return context
+
 
 class NimbusFeaturesView(TemplateView):
     template_name = "nimbus_experiments/features.html"