-
Notifications
You must be signed in to change notification settings - Fork 219
Closed
Closed
Copy link
Description
Because
- The
FmlClientconstructor (fromnimbus_megazord.fml) can raiseFmlError.ValidationErrorwhen a feature manifest has validation errors (e.g., a variable with bothgecko-prefanddefault, which are now mutually exclusive as of application-services build 150.20260321050323) NimbusFmlLoader.fml_client()does not catch this exception, so it propagates up and causes a 500 error on any page that callsget_invalid_fields_errors()(including the audience page during experiment creation)- This was discovered via failing Fenix integration tests on PR chore(nimbus): Update application-services #15002 (application-services version bump) — all
FIREFOX_FENIXtests failed withTimeoutExceptionbecause the audience page returned a 500
This issue
- Adds a
try/except FmlErroraround theFmlClient()constructor call inNimbusFmlLoader.fml_client()so that invalid manifests are logged and skipped rather than crashing the page - Adds unit tests verifying the graceful degradation
Related:
- Bugzilla bug 2025587 — upstream Fenix manifest fix for the
gecko-nimbus-validation.test-preferencevariable - PR chore(nimbus): Update application-services #15002 — application-services bump that exposes this
┆Issue is synchronized with this Jira Task
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels