-
Notifications
You must be signed in to change notification settings - Fork 219
Open
Description
Because
- When application-services added stricter FML validation (bug 2020683,
gecko-prefanddefaultare now mutually exclusive), the Fenix v149.0.0 manifests became unparseable byFmlClient - We had no unit test that actually loads each versioned FML manifest with
FmlClient— the existing "Check Local Feature Manifests" CI job only checks that manifests are up-to-date with what the manifest tool generates, not that they pass FML validation - This gap meant the breakage was only caught by integration tests timing out on a 500, not by a clear unit test failure
- See PR chore(nimbus): Update application-services #15002 and issue FmlClient constructor crash causes 500 when manifest has validation errors #15018 for the full investigation
This issue
- Add a unit test in
experimenter/features/tests/test_features.py(alongsideTestValidateFeatureManifests) that iterates all Application × Channel × Version combinations and callsFmlClient(path, channel)for each manifest file - Use
self.subTest()so failures identify the exact app/channel/version - This ensures that application-services updates and manifest syncs are caught early with a clear error message
Blocked by
- Bug 2025587 — the Fenix v149.0.0 manifest needs to be fixed upstream first (remove
defaultfromgecko-nimbus-validation.test-preference), otherwise this test will fail immediately on the current manifests
┆Issue is synchronized with this Jira Task
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels