Add open website from history test

Author: soncuteanca

modules/browser_object_panel_ui.py

@@ -1,6 +1,8 @@
+import random
 from time import sleep
-from typing import List
+from typing import List, Tuple
 
+import pytest
 from pypom import Region
 from selenium.common.exceptions import NoSuchElementException, TimeoutException
 from selenium.webdriver.remote.webelement import WebElement
@@ -191,6 +193,48 @@ def get_all_history(self) -> List[WebElement]:
             history_items = self.get_elements("bookmark-item")
             return history_items
 
+    @BasePage.context_chrome
+    def get_random_history_entry(self) -> Tuple[str, str]:
+        """
+        Retrieve a random browser history entry from the Panel UI.
+
+        This method ensures the History submenu is open, fetches all available
+        history items, selects one at random, extracts its URL and title, and
+        returns them after validating both are usable.
+        """
+        items = self.get_elements("bookmark-item")
+
+        if not items:
+            pytest.skip("No history available to test.")
+
+        item = random.choice(items)
+        raw_url = item.get_attribute("image")
+        label = item.get_attribute("label")
+
+        trimmed_url = self._extract_url_from_history(raw_url)
+        assert trimmed_url and label, "History item has missing URL or label."
+
+        return trimmed_url, label
+
+    def _extract_url_from_history(self, raw_url: str) -> str:
+        """
+            Extract a valid HTTP(S) URL from a raw history image attribute.
+
+        Firefox stores history URLs using special schemes like:
+            'moz-anno:favicon:https://example.com'
+        This method locates the first occurrence of "http" and returns the substring from there.
+
+        Args:
+            raw_url (str): The raw string value from the 'image' attribute of a history entry.
+        """
+        if not raw_url:
+            return ""
+
+        if "http" in raw_url:
+            return raw_url[raw_url.find("http") :]
+
+        return raw_url.strip()
+
     @BasePage.context_chrome
     def redirect_to_about_logins_page(self) -> BasePage:
         """

tests/bookmarks_and_history/test_open_websites_from_history.py

@@ -1,5 +1,3 @@
-import random
-
 import pytest
 from selenium.webdriver import Firefox
 
@@ -17,35 +15,20 @@ def use_profile():
     return "theme_change"
 
 
-def trim_url(url: str) -> str:
-    colon_index = url.find(":")
-    if colon_index != -1:
-        return url[colon_index + 1 :].strip()
-    else:
-        return ""
-
-
 def test_open_websites_from_history(driver: Firefox):
     """
-    C118807: Verify that the user can open websites from the Toolbar History submenu
+    C118807: Verify that the user can open any random website from Hamburger Menu, History section
     """
-    panel_ui = PanelUi(driver)
-    panel_ui.open()
 
-    panel_ui.open_history_menu()
+    # Instantiate objects
+    panel = PanelUi(driver)
+    panel.open_history_menu()
 
-    with driver.context(driver.CONTEXT_CHROME):
-        history_items = panel_ui.get_all_history()
-        if len(history_items) == 0:
-            assert False, "There is no history."
+    # Retrieve a random item from history and its label
+    url, label = panel.get_random_history_entry()
 
-        rand_index = random.randint(0, len(history_items) - 1)
-        url_to_visit = history_items[rand_index].get_attribute("image")
-        website_label = history_items[rand_index].get_attribute("label")
-
-        trimmed_url = trim_url(url_to_visit)
-    page = GenericPage(driver, url=trimmed_url)
+    # Open the corresponding page and verify URL and title match
+    page = GenericPage(driver, url=url)
     page.open()
-
-    page.url_contains(trimmed_url)
-    page.title_contains(website_label)
+    page.url_contains(url)
+    page.title_contains(label)