Skip to content

Commit 1656951

Browse files
authored
Ben/stabilize refresh fx (#789)
* add pref to refresh fx test * add pref to refresh fx test * allow rc on local * remove unstable * update test to match new test case
1 parent 6690abc commit 1656951

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

test_local_executables_updated.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def test_local_executables_updated(driver: Firefox, version):
2828
[sys.executable, "./collect_executables.py", "-n"], text=True
2929
).split("-")[0]
3030
local_fx_ver = version[16:]
31-
if latest_fx_ver != local_fx_ver:
31+
if latest_fx_ver != local_fx_ver and not local_fx_ver.endswith(".0"):
3232
print("You are not running the latest firefox version!!!")
3333
raise RuntimeError(
3434
f"Latest fx version is {latest_fx_ver} but you are running {local_fx_ver}"

tests/address_bar_and_search/test_refresh_firefox_dialog.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,23 @@ def test_case():
1313
return "3028765"
1414

1515

16-
@pytest.mark.unstable(
17-
reason="Fx change landed: bug 1958537, we're tracking in bug 1958537"
18-
)
16+
@pytest.fixture()
17+
def add_to_prefs_list():
18+
return [("browser.profiles.enabled", True)]
19+
20+
21+
@pytest.fixture()
22+
def use_profile():
23+
return "theme_change"
24+
25+
1926
def test_refresh_firefox_dialog(driver: Firefox):
2027
"""
2128
C2914620 - Verify that the 'Refresh Firefox' dialog appears from the address bar.
2229
"""
2330
nav = Navigation(driver)
2431
nav.type_in_awesome_bar(SEARCH_QUERY)
2532

26-
nav.click_on(REFRESH_BUTTON_ID)
27-
nav.element_visible(DIALOG_ID)
33+
# Bug 1928138 will restore Refresh Fx for some profiles
34+
nav.element_does_not_exist(REFRESH_BUTTON_ID)
35+
# nav.element_visible(DIALOG_ID)

0 commit comments

Comments
 (0)