Revert, modify

Author: soncuteanca

tests/downloads/test_add_mime_type_doc.py

@@ -15,7 +15,6 @@ def test_case():
 
 # Constants
 DOC_LINK = "https://sapphire-hendrika-5.tiiny.site/"
-WIN_GHA = environ.get("GITHUB_ACTIONS") == "true" and sys.platform.startswith("win")
 
 
 @pytest.fixture()
@@ -33,7 +32,6 @@ def expected_app_name(sys_platform: str, opt_ci: bool) -> str:
     return "LibreOffice Writer"
 
 
-# @pytest.mark.skipif(WIN_GHA, reason="Test unstable in Windows Github Actions")
 @pytest.mark.noxvfb
 def test_mime_type_doc(driver: Firefox, sys_platform: str, opt_ci: bool, delete_files):
     """

tests/downloads/test_add_zip_type.py

@@ -68,7 +68,7 @@ def test_add_zip_type(
     about_prefs.open()
     about_prefs.get_app_name_for_mime_type("application/zip")
 
-    # Remove the directory created as MacOS automatically unzips
+    # Remove the directory created as macOS automatically unzips
     if sys_platform == "Darwin":
         dir_created = os.path.join(home_folder, "Downloads", "api-guidelines-vNext")
         shutil.rmtree(dir_created)

tests/downloads/test_download_pdf_from_context_menu.py

@@ -36,18 +36,19 @@ def test_download_pdf_from_context_menu(
           must rely on fixed waits to give the OS time to render the dialog and to
           finish writing the file.
     """
+    # Any attempt to refactor this test make the test fail in CI, if time, it can be revised later.
 
     from pynput.keyboard import Controller
 
     # Initialize objects
     pdf = GenericPdf(driver, pdf_url=fillable_pdf_url)
-    keyboard = Controller()
-    context_menu = ContextMenu(driver)
-
-    # Open the PDF file, right-click on the body of the file and select Save page as
     pdf.open()
+    keyboard = Controller()
     body = pdf.get_element("pdf-body")
+
+    # Right-click on the body of the file and select Save page as
     pdf.context_click(body)
+    context_menu = ContextMenu(driver)
     context_menu.click_and_hide_menu("context-menu-save-page-as")
 
     # Allow time for the save dialog to appear and handle prompt
@@ -59,8 +60,7 @@ def test_download_pdf_from_context_menu(
     sleep(3)
 
     # Open about:telemetry and go to events tab
-    about_telemetry = AboutTelemetry(driver)
-    about_telemetry.open()
+    about_telemetry = AboutTelemetry(driver).open()
     about_telemetry.get_element("events-tab").click()
 
     # Verify that Telemetry is recorded