Skip to content

Commit 1adc7a2

Browse files
authored
Merge pull request #669 from mozilla/tracy/fix_third_party_tracker_test
DNT status test changes
2 parents 72b1839 + acdccc6 commit 1adc7a2

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

SELECTOR_INFO.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2135,8 +2135,8 @@ Path to .json: modules/data/generic_page.components.json
21352135
```
21362136
```
21372137
Selector Name: simulated-tracker-dnt-status
2138-
Selector Data: "dnt-on"
2139-
Description: The Do Not Track status
2138+
Selector Data: "dnt-ff"
2139+
Description: The Do Not Track (DNT) status
21402140
Location: Tracker test website
21412141
Path to .json: modules/data/generic_page.components.json
21422142
```

modules/data/generic_page.components.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
},
4949

5050
"simulated-tracker-dnt-status": {
51-
"selectorData": "dnt-on",
51+
"selectorData": "dnt-off",
5252
"strategy": "id",
5353
"groups": []
5454
},

tests/preferences/test_lang_pack_changed_from_about_prefs.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from platform import system
2+
13
import pytest
24
from selenium.common import TimeoutException
35
from selenium.webdriver import Firefox
@@ -26,6 +28,7 @@ def add_to_prefs_list():
2628
return [("services.sync.prefs.sync-seen.intl.accept_languages", True)]
2729

2830

31+
@pytest.mark.skipif(system().lower().startswith("win"), reason="Bug 1978595")
2932
def test_lang_pack_changed_from_about_prefs(driver: Firefox):
3033
"""
3134
C1771617 - The language can be changed in about:preferences.

tests/security_and_privacy/test_third_party_content_blocked_private_browsing.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ def test_third_party_content_blocked_private_browsing_allowed_tracking(driver: F
103103
assert item.get_attribute("value") in ALLOWED_TRACKING_URLS
104104

105105

106-
@pytest.mark.skip(reason="Bug 1973795")
107106
def test_third_party_content_private_browsing_tracking_statuses(driver: Firefox):
108107
"""
109108
C446323.3: Ensure that the statuses of some third party content are loaded properly
@@ -132,4 +131,4 @@ def test_third_party_content_private_browsing_tracking_statuses(driver: Firefox)
132131

133132
assert "hidden" not in block_status.get_attribute("class")
134133
assert "hidden" not in load_status.get_attribute("class")
135-
assert "hidden" not in dnt_status.get_attribute("class")
134+
assert "incorrect" in dnt_status.get_attribute("class")

0 commit comments

Comments
 (0)