Merge pull request #130 from mozilla/sl/private-browsing-password-doorhanger

Private Browsing Login Doorhanger

Author: sarinali

modules/data/login_autofill.components.json

@@ -1,9 +1,33 @@
 {
-    "login-input-field": {
+    "input-field": {
         "selectorData": "input[autocomplete='{name}']",
         "strategy": "css",
         "groups": [
             "doNotCache"
         ]
+    },
+
+    "username-field": {
+        "selectorData": "input[placeholder='username']",
+        "strategy": "css",
+        "groups": [
+            "doNotCache"
+        ]
+    },
+
+    "submit-form": {
+        "selectorData": "input[value='Log In']",
+        "strategy": "css",
+        "groups": [
+            "doNotCache"
+        ]
+    },
+
+    "save-login-popup": {
+        "selectorData": "notification-popup",
+        "strategy": "id",
+        "groups": [
+            "doNotCache"
+        ]
     }
 }

modules/page_object.py

@@ -9,6 +9,7 @@
 from modules.page_object_about_telemetry import *
 from modules.page_object_addons_mozilla_org import *
 from modules.page_object_autofill_credit_card import *
+from modules.page_object_autofill_login import *
 from modules.page_object_autofill_test_basic import *
 from modules.page_object_example_page import *
 from modules.page_object_fxa_home import *

modules/page_object_autofill_login.py

@@ -1,3 +1,5 @@
+from selenium.webdriver import Firefox
+
 from modules.page_object_autofill import Autofill
 
 
@@ -7,3 +9,34 @@ class LoginAutofill(Autofill):
     """
 
     URL_TEMPLATE = "https://mozilla.github.io/form-fill-examples/password_manager/login_and_pw_change_forms.html"
+
+    class LoginForm:
+        """
+        Sub class of the Login Autofill Form where you can interact with the Login Form
+        """
+
+        def __init__(self, parent: "LoginAutofill") -> None:
+            self.parent = parent
+            self.username_field = None
+            self.password_field = None
+            self.submit_button = None
+
+        def fill_username(self, username: str) -> None:
+            if self.username_field is None:
+                username_fields = self.parent.get_elements("username-field")
+                self.username_field = username_fields[1]
+            self.username_field.send_keys(username)
+
+        def fill_password(self, password: str) -> None:
+            if self.password_field is None:
+                password_fields = self.parent.get_elements(
+                    "input-field", labels=["current-password"]
+                )
+                self.password_field = password_fields[0]
+            self.password_field.send_keys(password)
+
+        def submit(self) -> None:
+            if self.submit_button is None:
+                submit_buttons = self.parent.get_elements("submit-form")
+                self.submit_button = submit_buttons[0]
+            self.submit_button.click()

tests/menus/test_copy_paste_actions.py

@@ -18,14 +18,12 @@ def test_login_form_copy_paste(driver: Firefox):
     random_text = util.generate_random_text("sentence")
 
     # get the field and send text
-    password_field = login_fill.get_element(
-        "login-input-field", labels=["current-password"]
-    )
+    password_field = login_fill.get_element("input-field", labels=["current-password"])
     password_field.send_keys(random_text)
     logging.info(f"Sent the text {random_text} to the textarea.")
 
     # triple click and copy text
-    login_fill.triple_click("login-input-field", labels=["current-password"])
+    login_fill.triple_click("input-field", labels=["current-password"])
     login_fill.context_click(password_field)
     context_menu.click_and_hide_menu("context-menu-copy")
 

tests/security_and_privacy/test_private_browser_password_doorhanger.py

@@ -0,0 +1,37 @@
+import pytest
+from selenium.webdriver import Firefox
+
+from modules.browser_object import Navigation, PanelUi
+from modules.page_object import LoginAutofill
+
+SAMPLE_USER = "bob_c"
+SAMPLE_PASS = "123456"
+
+
+@pytest.fixture()
+def add_prefs():
+    return [("signon.rememberSignons", True)]
+
+
+def test_no_password_doorhanger_private_browsing(driver: Firefox):
+    """
+    C101670: Ensure no save password doorhanger shows up and settings are correct
+    """
+    # instantiate objects
+    login_auto_fill = LoginAutofill(driver)
+    panel_ui = PanelUi(driver).open()
+    nav = Navigation(driver)
+    panel_ui.open_private_window()
+    nav.switch_to_new_window()
+
+    # open the form, fill the user and password
+    login_auto_fill.open()
+    login_form = LoginAutofill.LoginForm(login_auto_fill)
+    login_form.fill_username(SAMPLE_USER)
+    login_form.fill_password(SAMPLE_PASS)
+    login_form.submit()
+
+    # ensure that the panel is not open
+    with driver.context(driver.CONTEXT_CHROME):
+        save_pass_panel = login_auto_fill.get_element("save-login-popup")
+        assert save_pass_panel.get_attribute("panelopen") is None