Merge pull request #644 from mozilla/philimon/password_fix

Philimon/primary_password_trigger_test_fix

Author: philimon-reset

l10n_CM/run_l10n.py

@@ -13,7 +13,15 @@
 valid_flags = {"--run-headless", "-n", "--reruns", "--fx-executable", "--ci"}
 flag_with_parameter = {"-n", "--reruns"}
 valid_region = {"US", "CA", "DE", "FR"}
-valid_sites = {"demo", "amazon", "walmart", "mediamarkt", "lowes", "etsy", "calvinklein"}
+valid_sites = {
+    "demo",
+    "amazon",
+    "walmart",
+    "mediamarkt",
+    "lowes",
+    "etsy",
+    "calvinklein",
+}
 live_sites = []
 
 LOCALHOST = "127.0.0.1"

tests/password_manager/test_primary_password_triggered_on_about_logins_access.py

@@ -73,7 +73,6 @@ def test_primary_password_triggered_on_about_logins_access_via_hamburger_menu(
     # Attempt to view the saved password in order to trigger the primary password prompt
     about_logins.element_visible("show-password-checkbox")
     about_logins.click_on("show-password-checkbox")
-
     # Dismiss the primary password prompt without entering the password
     with driver.context(driver.CONTEXT_CHROME):
         driver.switch_to.window(driver.window_handles[-1])
@@ -84,9 +83,9 @@ def test_primary_password_triggered_on_about_logins_access_via_hamburger_menu(
     tabs.switch_to_new_tab()
     panel_ui.open_panel_menu()
     panel_ui.redirect_to_about_logins_page()
-
     # Verify that the primary password prompt appears and enter the primary password
     with driver.context(driver.CONTEXT_CHROME):
+        tabs.wait_for_num_tabs(2)
         driver.switch_to.window(driver.window_handles[-1])
         # Fetch a fresh reference to avoid staling
         primary_password_prompt = about_logins.get_element("primary-password-prompt")