private browsing closing tab not working

Author: sarinali

modules/browser_object_panel_ui.py

@@ -132,3 +132,12 @@ def start_sync(self) -> BasePage:
             self.element_has_text("fxa-sync-label", "Sync now")
             self.get_element("fxa-sync-label").click()
         return self
+
+    def open_private_window(self) -> BasePage:
+        """
+        Opens a new window in private browsing mode using the panel
+        """
+        self.open_panel_menu()
+        with self.driver.context(self.driver.CONTEXT_CHROME):
+            self.get_element("panel-ui-new-private-window").click()
+        return self

modules/browser_object_tabbar.py

@@ -244,3 +244,12 @@ def get_bar_y():
             self.actions.move_by_offset(0, (sign * pixels))
             self.actions.release()
             self.actions.perform()
+
+    def close_tab_of_index(self, index: int) -> BasePage:
+        """
+        Given the index of the tab, it closes that tab.
+        """
+        cur_tab = self.click_tab_by_index(index)
+        with self.driver.context(self.driver.CONTEXT_CHROME):
+            self.get_element("tab-x-icon", parent_element=cur_tab).click()
+        return self

modules/data/navigation.components.json

@@ -9,6 +9,14 @@
         ]
     },
 
+    "awesome-bar-private": {
+        "selectorData": "urlbar-input",
+        "strategy": "id",
+        "groups": [
+            "awesomeBar"
+        ]
+    },
+
     "results-dropdown": {
         "selectorData": "urlbar-results",
         "strategy": "id",

modules/data/panel_ui.components.json

@@ -107,6 +107,12 @@
         "selectorData": "toolbarbutton[class='restoreallitem subviewbutton panel-subview-footer-button']",
         "strategy": "css",
         "groups": []
+    },
+
+    "panel-ui-new-private-window": {
+        "selectorData": "appMenu-new-private-window-button2",
+        "strategy": "id",
+        "groups": []
     }
 
 }

modules/page_object_about_prefs.py

@@ -10,7 +10,7 @@
 from modules.classes.autofill_base import AutofillAddressBase
 from modules.classes.credit_card import CreditCardBase
 from modules.page_base import BasePage
-from modules.util import BrowserActions, PomUtils
+from modules.util import PomUtils
 
 
 class AboutPrefs(BasePage):

tests/address_bar_and_search/test_google_search_counts_us.py

@@ -1,6 +1,5 @@
 from time import sleep
 
-import pytest
 from selenium.webdriver import Firefox
 
 from modules.browser_object import Navigation

tests/preferences/test_clear_cookie_data.py

@@ -27,12 +27,12 @@ def open_clear_cookies_data_dialog():
 
     # Check for a non-zero value of the 'Cookies and site data' option
     cookie_value = about_prefs.get_clear_cookie_data_value()
-    assert cookie_value is not 0
+    assert cookie_value != 0
 
     # Then clear the cookies and site data
     about_prefs.get_element("clear-data-accept-button").click()
 
     # Finally, check the value of the dialog option, it should be 0
     open_clear_cookies_data_dialog()
     cookie_value2 = about_prefs.get_clear_cookie_data_value()
-    assert cookie_value2 is 0
+    assert cookie_value2 == 0

tests/security_and_privacy/test_undo_close_tab_private_browsing.py

@@ -0,0 +1,58 @@
+from time import sleep
+
+import pytest
+from selenium.webdriver import Firefox
+from selenium.webdriver.common.keys import Keys
+
+from modules.browser_object import Navigation, PanelUi, TabBar
+
+VISIT_URL = "about:about"
+
+links = [
+    "about:about",
+    "about:addons",
+    "about:cache",
+    "about:config",
+    "about:buildconfig",
+    "about:robots",
+    "about:blank",
+]
+
+link_set = set(links)
+
+
+@pytest.fixture()
+def add_prefs():
+    return []
+
+
+def test_undo_close_tab_private_browsing(driver: Firefox):
+    """
+    C120118: ensure that you can close a tab in private browsing window
+    """
+    # instantiate objs
+    panel_ui = PanelUi(driver)
+    nav = Navigation(driver).open()
+    tabs = TabBar(driver)
+
+    # open a new private window and open a new tab
+    panel_ui.open_private_window()
+    tabs.switch_to_new_tab()
+
+    # open a new tab
+    tabs.new_tab_by_button()
+    tabs.switch_to_new_tab()
+
+    # navigate to the URL NOTE: TEMPORARY GET AWESOME BAR PRIVATE. ADD SUPPORT FOR IT IN NAVIGATION
+    with driver.context(driver.CONTEXT_CHROME):
+        search_bar = nav.get_element("awesome-bar-private")
+        search_bar.send_keys(VISIT_URL + Keys.ENTER)
+    tabs.wait_for_num_tabs(3)
+    # tabs.switch_to_new_tab()
+    # for _ in range(100):
+    #     print(len(driver.window_handles))
+    #     sleep(0.5)
+
+    tabs.close_tab_of_index(0)
+
+    sleep(40)