Merge pull request #152 from mozilla/tw/manage_cookie_data

Create test and add PoM objects and methods.

Author: Tracy-Walker

modules/data/about_prefs.components.json

@@ -272,6 +272,15 @@
         ]
     },
 
+    "manage-data-save-changes-button": {
+        "selectorData": "[class='button-text'][value='Save Changes']",
+        "strategy": "css",
+        "shadowParent": "cookies-shadow-root",
+        "groups": [
+            "doNotCache"
+        ]
+    },
+
     "permissions-notifications-button": {
         "selectorData": "notificationSettingsButton",
         "strategy": "id",
@@ -344,12 +353,24 @@
         "groups": []
     },
 
+    "manage-cookies-site": {
+        "selectorData": "richlistitem[host='{name}']",
+        "strategy": "css",
+        "groups": []
+    },
+
     "language-set-alternative-button": {
         "selectorData": "[data-l10n-id='manage-browser-languages-button']",
         "strategy": "css",
         "groups": []
     },
 
+    "remove-selected-button": {
+        "selectorData": "removeSelected",
+        "strategy": "id",
+        "groups": []
+    },
+
     "language-settings-content": {
         "selectorData": "[data-l10n-id='browser-languages-window2']",
         "strategy": "css",
@@ -362,6 +383,12 @@
         "groups": []
     },
 
+    "remove-all-button": {
+        "selectorData": "removeAll",
+        "strategy": "id",
+        "groups": []
+    },
+
     "language-settings-select": {
         "selectorData": "[data-l10n-id='browser-languages-select-language']",
         "strategy": "css",
@@ -415,5 +442,23 @@
         "selectorData": "historyMode",
         "strategy": "id",
         "groups": []
+    },
+
+    "manage-cookies-site": {
+        "selectorData": "richlistitem[host='{name}']",
+        "strategy": "css",
+        "groups": []
+    },
+
+    "remove-selected-button": {
+        "selectorData": "removeSelected",
+        "strategy": "id",
+        "groups": []
+    },
+
+    "remove-all-button": {
+        "selectorData": "removeAll",
+        "strategy": "id",
+        "groups": []
     }
 }

modules/page_object_about_prefs.py

@@ -317,6 +317,13 @@ def get_clear_cookie_data_value(self) -> int:
         else:
             print("No number found in the string")
 
+    def get_manage_data_site_element(self, site: str) -> WebElement:
+        """
+        Returns the WebElement for the given site in the manage site data popup
+        """
+        element = self.get_element("manage-cookies-site", labels=[site])
+        return element
+
     def get_iframe(self) -> WebElement:
         """
         Gets the webelement for the iframe that commonly appears in about:preferences

tests/bookmarks_and_history/test_bookmark_via_bookmark_menu.py

@@ -23,4 +23,4 @@ def test_bookmark_via_bookmark_menu(driver: Firefox):
 
     # Verify that the bookmark is displayed in bookmarks menu
     panel.open_bookmarks_menu()
-    panel.element_visible("bookmark-by-title", labels=["Internet for people"])
+    panel.element_visible("bookmark-by-title", labels=["Internet for people"])

tests/preferences/test_manage_cookie_data.py

@@ -0,0 +1,83 @@
+from time import sleep
+
+import pytest
+from pynput.keyboard import Controller, Key
+from selenium.webdriver import Firefox
+
+from modules.page_object import AboutPrefs
+from modules.util import BrowserActions
+
+COOKIE_SITE = "google.com"
+
+
+@pytest.mark.headed
+def test_manage_cookie_data(driver: Firefox):
+    """
+    C143633 - Cookies and Site Data can be managed
+    via the "Managed Cookies and Site Data" pane
+    """
+    # Instantiate objects
+    about_prefs = AboutPrefs(driver, category="privacy")
+    ba = BrowserActions(driver)
+    keyboard = Controller()
+
+    def open_manage_cookies_data_dialog():
+        about_prefs.open()
+        manage_data_popup = about_prefs.press_button_get_popup_dialog_iframe(
+            "Manage Data…"
+        )
+        ba.switch_to_iframe_context(manage_data_popup)
+
+    # Visit some sites to get a few cookies added to saved data
+    driver.get("https://www.google.com")
+    driver.get("https://www.jetbrains.com")
+    driver.get("https://www.wikipedia.com")
+
+    # Navigate to the manage data dialog of about:preferences#privacy
+    open_manage_cookies_data_dialog()
+
+    # Click on one of the items from the list.
+    cookie_item = about_prefs.get_manage_data_site_element(COOKIE_SITE)
+    cookie_item.click()
+
+    # The clicked on site in the list is highlighted
+    selected = cookie_item.get_attribute("selected")
+    assert selected == "true"
+
+    # Click the "Remove Selected" button.
+    about_prefs.get_element("remove-selected-button").click()
+
+    # The selected item is removed from the list.
+    about_prefs.element_does_not_exist("manage-cookies-site", labels=[COOKIE_SITE])
+
+    # Click on the "Remove All" button and wait for changes to take.
+    about_prefs.get_element("remove-all-button").click()
+    sleep(1)
+
+    # All the sites are removed from the list.
+    # NOTE: There seems to be an empty placeholder element, thus 1 item is always there.
+    cookie_list = about_prefs.get_elements("cookies-manage-data-sitelist")
+    assert len(cookie_list) == 1
+
+    # Click on "Save Changes" button and wait for changes to take.
+    about_prefs.get_element("manage-data-save-changes-button").click()
+    sleep(1)
+
+    # Using pynput, navigate to the "Remove" button of the acceptance dialog/alert,
+    # then send the Enter key and wait for changes to take
+    keyboard.press(Key.tab)
+    keyboard.release(Key.tab)
+    sleep(0.5)
+    keyboard.press(Key.tab)
+    keyboard.release(Key.tab)
+    sleep(0.5)
+    keyboard.press(Key.enter)
+    keyboard.release(Key.enter)
+    sleep(1)
+
+    # Navigate back to the manage data dialog of about:preferences#privacy
+    open_manage_cookies_data_dialog()
+
+    # All the cookies and site data are deleted.
+    cookie_list_post_remove = about_prefs.get_elements("cookies-manage-data-sitelist")
+    assert len(cookie_list_post_remove) == 1  # NOTE: always an empty item here