Philimon/hover verify (#508)

* initial way to verify hover autofill

* finished adding test for hover verify

* furture improvements to l10n suite and verify hover test

* forgot to add selector in docs

* removed useless method

Author: philimon-reset

SELECTOR_INFO.md

@@ -1361,6 +1361,13 @@ Location: Inside any autofill-eligible form field, triggered by user interaction
 Path to .json: modules/data/autofill_popup.components.json
 ```
 ```
+Selector Name: address-preview-form-container
+Selector Data: "address-save-update-notification-content"
+Description: Form container that is hidden in chrome context. Used to verify hover preview data
+Location: Inside chrome context, holds the data that would be showed as a preview when autofill is hovered.
+Path to .json: modules/data/autofill_popup.components.json
+```
+```
 Selector Name: doorhanger-save-button
 Selector Data: button[label='Save'].popup-notification-primary-button
 Description: The "Save" button 

l10n_CM/Unified/test_demo_ad_address_data_captured_in_doorhanger_and_stored.py

@@ -66,6 +66,7 @@ def test_demo_ad_address_data_captured_in_doorhanger_and_stored(
 
     # Navigate to about:preferences#privacy => "Autofill" section
     about_prefs_privacy.open()
+    about_prefs_privacy.get_saved_addresses_popup().click()
     about_prefs_privacy.switch_to_saved_addresses_popup_iframe()
 
     # Verify saved addresses

l10n_CM/Unified/test_demo_ad_email_phone_captured_in_doorhanger_and_stored.py

@@ -42,10 +42,8 @@ def test_demo_ad_email_phone_captured_in_doorhanger_and_stored(
     if expected_phone:
         with driver.context(driver.CONTEXT_CHROME):
             actual_phone = autofill_popup.get_element("address-doorhanger-phone").text
-        normalize_expected = util.normalize_regional_phone_numbers(
-            expected_phone, region
-        )
-        normalized_actual = util.normalize_regional_phone_numbers(actual_phone, region)
+        normalize_expected = util.normalize_phone_number(expected_phone, region)
+        normalized_actual = util.normalize_phone_number(actual_phone, region)
         assert normalized_actual == normalize_expected, (
             f"Phone number mismatch for {region} | Expected: {normalize_expected}, Got: {normalized_actual}"
         )
@@ -55,6 +53,7 @@ def test_demo_ad_email_phone_captured_in_doorhanger_and_stored(
 
     # Navigate to about:preferences#privacy => "Autofill" section
     about_prefs_privacy.open()
+    about_prefs_privacy.get_saved_addresses_popup().click()
     about_prefs_privacy.switch_to_saved_addresses_popup_iframe()
 
     # The address saved in step 2 is listed in the "Saved addresses" modal: Email and phone

l10n_CM/Unified/test_demo_ad_hover_verify_address.py

@@ -0,0 +1,53 @@
+import logging
+
+import pytest
+from selenium.webdriver import ActionChains, Firefox
+
+from modules.browser_object_autofill_popup import AutofillPopup
+from modules.page_object_autofill import AddressFill
+from modules.page_object_prefs import AboutPrefs
+from modules.util import Utilities
+
+
+@pytest.fixture()
+def test_case():
+    return "2888562"
+
+
+@pytest.fixture()
+def add_to_prefs_list(region: str):
+    return [
+        ("extensions.formautofill.creditCards.supportedCountries", region),
+        ("extensions.formautofill.addresses.supported", "on"),
+    ]
+
+
+def test_hover_address_is_previewed(
+    driver: Firefox,
+    region: str,
+    about_prefs_privacy: AboutPrefs,
+    address_autofill: AddressFill,
+    autofill_popup: AutofillPopup,
+    util: Utilities,
+):
+    """
+    C2888562: Verify that hovering over field will preview all fields
+    """
+    # Create fake data and fill it in
+    address_autofill.open()
+    address_autofill_data = util.fake_autofill_data(region)
+    address_autofill.save_information_basic(address_autofill_data)
+
+    # Click the "Save" button
+    autofill_popup.click_doorhanger_button("save")
+    # Hover over each field and check data preview
+    for field in AddressFill.fields:
+        # hack to pass over fields that don't show up in autofill dropdown
+        if field == "address-level1" and region in ["DE", "FR"]:
+            continue
+        address_autofill.double_click("form-field", labels=[field])
+        autofill_popup.ensure_autofill_dropdown_visible()
+        autofill_popup.hover("select-form-option")
+        address_autofill.verify_autofill_data_on_hover(
+            address_autofill_data, autofill_popup, util
+        )

l10n_CM/Unified/test_demo_ad_name_org_captured_in_doorhanger_and_stored.py

@@ -44,6 +44,7 @@ def test_demo_ad_name_org_captured_in_doorhanger_and_stored(
 
     # Navigate to about:preferences#privacy => "Autofill" section
     about_prefs_privacy.open()
+    about_prefs_privacy.get_saved_addresses_popup().click()
     about_prefs_privacy.switch_to_saved_addresses_popup_iframe()
 
     # The address saved in step 2 is listed in the "Saved addresses" modal: name and organization

l10n_CM/Unified/test_demo_ad_yellow_highlight_address.py

@@ -21,24 +21,20 @@ def test_address_yellow_highlight_address_fields(
     """
     C2888564 - Verify the yellow highlight appears on autofilled fields for the address fields.
     """
-
-    # Instantiate objects
-    address_autofill_popup = AutofillPopup(driver)
-
     # Create fake data and fill it in
     address_autofill.open()
     address_autofill_data = util.fake_autofill_data(region)
     address_autofill.save_information_basic(address_autofill_data)
 
     # Click the "Save" button
-    address_autofill_popup.click_doorhanger_button("save")
+    autofill_popup.click_doorhanger_button("save")
 
     # Double click inside street address field and select a saved address entry from the dropdown
     address_autofill.double_click("form-field", labels=["street-address"])
 
     # Click on the first element from the autocomplete dropdown
-    first_item = address_autofill_popup.get_nth_element(1)
-    address_autofill_popup.click_on(first_item)
+    first_item = autofill_popup.get_nth_element(1)
+    autofill_popup.click_on(first_item)
 
     # Verify the address fields are highlighted
     address_autofill.verify_field_yellow_highlights(

l10n_CM/region/Unified.json

@@ -22,6 +22,7 @@
     "test_demo_ad_clear_name_org.py",
     "test_demo_ad_clear_address_fields.py",
     "test_demo_ad_clear_tel_email.py",
-    "test_demo_ad_autofill_dropdown_present_for_email_and_phone.py"
+    "test_demo_ad_autofill_dropdown_present_for_email_and_phone.py",
+    "test_demo_ad_hover_verify_address.py"
   ]
 }

modules/data/autofill_popup.components.json

@@ -155,6 +155,12 @@
         "selectorData": "div.address-save-update-row-container:nth-of-type(1) div p:nth-of-type(5) span",
         "strategy": "css",
         "groups": []
+    },
+
+    "address-preview-form-container": {
+        "selectorData": "address-save-update-notification-content",
+        "strategy": "class",
+        "groups": []
     }
 }
 

modules/page_base.py

@@ -708,6 +708,11 @@ def switch_to_default_frame(self) -> Page:
         self.driver.switch_to.default_content()
         return self
 
+    def switch_to_iframe(self, index: int):
+        """Switch to frame of given index"""
+        self.driver.switch_to.frame(index)
+        return self
+
     def switch_to_new_tab(self) -> Page:
         """Get list of all window handles, switch to the newly opened tab"""
         with self.driver.context(self.driver.CONTEXT_CONTENT):

modules/page_object_autofill.py

@@ -1,6 +1,8 @@
 import logging
+from html import unescape
 from typing import List, Optional
 
+from selenium.webdriver.common.by import By
 from selenium.webdriver.support import expected_conditions as EC
 
 from modules.browser_object_autofill_popup import AutofillPopup
@@ -276,8 +278,9 @@ def update_credit_card_information(
         else:
             autofill_popup_obj.click_on("doorhanger-save-button")
 
+    @staticmethod
     def extract_credit_card_obj_into_list(
-        self, credit_card_sample_data: CreditCardBase
+        credit_card_sample_data: CreditCardBase,
     ) -> List[str]:
         """
         Extracts the credit card information from the object and returns it as a list.
@@ -511,15 +514,13 @@ def send_keys_to_element(self, name: str, label: str, keys: str):
         elem.clear()
         elem.send_keys(new_value)
 
-    def verify_autofill_data(
-        self, autofill_data: AutofillAddressBase, region: str, util: Utilities
-    ):
+    def verify_autofill_data(self, autofill_data: AutofillAddressBase, util: Utilities):
         """
         Verifies that the autofill data matches the expected values.
 
-        :param autofill_data: AutofillAddressBase object containing expected data.
-        :param region: The region code (e.g., "US", "DE", "FR").
-        :param util: Utilities instance to normalize values.
+        Arguments:
+            autofill_data: AutofillAddressBase object containing expected data.
+            util: Utilities instance to normalize values.
         """
         field_mapping = {
             "Name": "name-field",
@@ -550,21 +551,64 @@ def verify_autofill_data(
             "Country": autofill_data.country_code,
             "Email": autofill_data.email,
             "Phone": util.normalize_regional_phone_numbers(
-                autofill_data.telephone, region
+                autofill_data.telephone, autofill_data.country_code
             ),
         }
 
+        self.verify_data(actual_values, expected_values, util)
+
+    @BasePage.context_chrome
+    def verify_autofill_data_on_hover(
+        self,
+        autofill_data: AutofillAddressBase,
+        autofill_popup: AutofillPopup,
+        util: Utilities,
+    ):
+        """
+        Verifies that the autofill preview data matches the expected values when hovering
+
+        Arguments:
+            autofill_data: AutofillAddressBase object containing expected data.
+            autofill_popup: AutofillPopup object to get element from dropdown.
+            util: Utilities instance to normalize values.
+        """
+
+        # get preview data from hovering through the chrome context
+        element = autofill_popup.get_element("address-preview-form-container")
+        # get every span element that is a child of the form and is not empty
+        children = [
+            x.get_attribute("innerHTML")
+            for x in element.find_elements(By.TAG_NAME, "span")
+            if len(x.get_attribute("innerHTML").strip()) >= 2
+        ]
+
+        # normalize phone number data
+        autofill_data.telephone = util.normalize_regional_phone_numbers(
+            autofill_data.telephone, autofill_data.country_code
+        )
+        for expected in children:
+            if expected[0] == "+":
+                expected = util.normalize_phone_number(expected)
+            if len(expected) == 2 and expected != autofill_data.country_code:
+                continue
+            assert unescape(expected) in autofill_data.__dict__.values(), (
+                f"Mismatched data: {expected} not in {autofill_data}."
+            )
+
+    @staticmethod
+    def verify_data(actual_values, expected_values, util: Utilities):
+        """Verify data between actual and expected values"""
         # Validate each field
         for field, expected in expected_values.items():
             actual = actual_values[field]
 
             # Skip State verification for DE and FR
-            if field == "State" and region in ["DE", "FR"]:
+            if field == "State" and expected_values["Country"] in ["DE", "FR"]:
                 continue
 
             # Normalize phone numbers before comparison
             if field == "Phone":
-                actual = util.normalize_regional_phone_numbers(actual, region)
+                actual = util.normalize_phone_number(actual)
 
             assert actual == expected, (
                 f"Mismatch in {field}: Expected '{expected}', but got '{actual}'"
@@ -631,9 +675,7 @@ def autofill_and_verify(
         address_autofill_popup.click_on(first_item)
 
         # Verify autofill data
-        self.verify_autofill_data(
-            address_autofill_data, address_autofill_data.country_code, util
-        )
+        self.verify_autofill_data(address_autofill_data, util)
 
         # Clear form autofill
         self.double_click("form-field", labels=[field_label])