Update methods

Author: soncuteanca

modules/browser_object_navigation.py

@@ -658,3 +658,11 @@ def expect_bookmarks_toolbar_visibility(self, expected: bool) -> None:
         self.expect_element_attribute_contains(
             self.bookmarks_toolbar, "collapsed", expected_value
         )
+
+    def open_audio_video_permission(self) -> BasePage:
+        """Open the Site information panel and select "Allow Audio and Video" """
+        self.click_on("autoplay-icon-blocked")
+        self.element_clickable("permission-popup-audio-blocked")
+        self.click_on("permission-popup-audio-blocked")
+        self.click_and_hide_menu("allow-audio-video-menuitem")
+        return self

modules/page_object_prefs.py

@@ -561,6 +561,16 @@ def get_manage_data_site_element(self, site: str) -> WebElement:
         element = self.get_element("manage-cookies-site", labels=[site])
         return element
 
+    def open_autopaly_modal(self) -> BasePage:
+        """
+        Opens the Autoplay settings modal dialog from the about:preferences#privacy page.
+        """
+        self.open()
+        self.click_on("autoplay-settings-button")
+        self.driver.switch_to.frame(self.get_iframe())
+        self.click_on("autoplay-settings")
+        return self
+
     def set_autoplay_setting(
         self,
         settings: Literal[
@@ -577,12 +587,7 @@ def set_autoplay_setting(
             - "block-audio-video": Block both audio and video autoplay
             - "allow-audio-only": Allow audio but block video autoplay
         """
-        self.open()
-        self.click_on("autoplay-settings-button")
-
-        self.driver.switch_to.frame(self.get_iframe())
-
-        self.click_on("autoplay-settings")
+        self.open_autopaly_modal()
         self.click_on(settings)
         self.click_on("spacer")
         self.click_on("autoplay-save-changes")

tests/audio_video/test_allow_audio_video_functionality.py

@@ -20,7 +20,7 @@ def test_case():
 TEST_URL = "https://www.mlb.com/video/rockies-black-agree-on-extension"
 
 
-# @pytest.mark.skipif(WIN_GHA, reason="Test unstable in Windows Github Actions")
+@pytest.mark.skipif(WIN_GHA, reason="Test unstable in Windows Github Actions")
 @pytest.mark.audio
 @pytest.mark.noxvfb
 def test_allow_audio_video_functionality(driver: Firefox):

tests/audio_video/test_users_actions_saved_on_reload.py

@@ -4,7 +4,6 @@
 from modules.browser_object_navigation import Navigation
 from modules.page_object_generics import GenericPage
 from modules.page_object_prefs import AboutPrefs
-from modules.util import BrowserActions
 
 
 @pytest.fixture()
@@ -30,15 +29,13 @@ def test_users_actions_saved_on_reload(driver: Firefox):
     # Instantiate objects
     nav = Navigation(driver)
     about_prefs = AboutPrefs(driver, category="privacy")
-    ba = BrowserActions(driver)
+    page = GenericPage(driver, url=TEST_URL)
 
     # Open Test page
-    GenericPage(driver, url=TEST_URL).open()
+    page.open()
 
-    # Open the Site information panel and check "Allow Audio and Video"
-    nav.click_on("autoplay-icon-blocked")
-    nav.click_on("permission-popup-audio-blocked")
-    nav.click_and_hide_menu("allow-audio-video-menuitem")
+    # Open the Audio-Video Permission panel and check "Allow Audio and Video"
+    nav.open_audio_video_permission()
 
     # Refresh test page and check the site information panel shows "Allow Audio and Video"
     driver.get(driver.current_url)
@@ -48,17 +45,11 @@ def test_users_actions_saved_on_reload(driver: Firefox):
     nav.element_not_visible("autoplay-icon-blocked")
 
     # Check the website is added to the exceptions list in about:preferences#privacy
-    about_prefs.open()
-    about_prefs.get_element("autoplay-settings-button").click()
-
-    # Get the web element for the iframe
-    iframe = about_prefs.get_iframe()
-    ba.switch_to_iframe_context(iframe)
-
+    about_prefs.open_autopaly_modal()
     about_prefs.element_visible("mlb-allow-audio-video-settings")
 
-    # Open Test page
-    GenericPage(driver, url=TEST_URL).open()
+    # # Open Test page
+    page.open()
 
     # Open the Site information panel and check "Block Audio and Video"
     nav.click_on("autoplay-icon-blocked")
@@ -71,7 +62,7 @@ def test_users_actions_saved_on_reload(driver: Firefox):
     nav.element_visible("autoplay-icon-blocked")
 
     # Revisit test page and check Site information panel shows "Block Audio and Video"
-    GenericPage(driver, url=TEST_URL).open()
+    page.open()
     nav.element_visible("permission-popup-audio-video-blocked")
 
     # Check the Crossed off Play icon is displayed