format

Author: sarinali

modules/page_base.py

@@ -551,6 +551,16 @@ def wait_for_num_tabs(self, num_tabs: int) -> Page:
             logging.warn("Timeout waiting for the number of windows to be:", num_tabs)
         return self
 
+    def wait_for_no_children(
+        self, parent: Union[str, tuple, WebElement], labels=[]
+    ) -> Page:
+        """
+        Waits for 0 children under the given parent, the wait is instant
+        """
+        self.instawait.until(
+            lambda _: len(self.get_all_children(self.fetch(parent, labels))) == 0
+        )
+
     def switch_to_new_tab(self) -> Page:
         """Get list of all window handles, switch to the newly opened tab"""
         handles = self.driver.window_handles

tests/security_and_privacy/test_cookies_not_saved_private_browsing.py

@@ -39,9 +39,5 @@ def test_cookies_not_saved_private_browsing(driver: Firefox):
     iframe = about_prefs.get_iframe()
     ba.switch_to_iframe_context(iframe)
 
-    # ensure none are listed
-    sitelist = about_prefs.get_element("cookies-manage-data-sitelist")
-    sites = about_prefs.get_all_children(sitelist)
-
-    # note when there are 0 children, this is a bit slow
-    assert len(sites) == 0
+    # wait for no children listed in the cookies menu
+    about_prefs.wait_for_no_children("cookies-manage-data-sitelist")