Skip to content

Commit 3d8545a

Browse files
authored
Merge pull request #145 from mozilla/sl/batch4-pom-bom
Batch 4 Very General POM and BOMs
2 parents 4107aa0 + 8456ff3 commit 3d8545a

File tree

10 files changed

+56
-6
lines changed

10 files changed

+56
-6
lines changed

modules/browser_object_pdf_viewer.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
from modules.page_base import BasePage
2+
3+
4+
class PdfViewer(BasePage):
5+
"""
6+
BOM for PDF viewer
7+
"""
8+
9+
URL_TEMPLATE = ""

modules/browser_object_reader_view.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
from modules.page_base import BasePage
2+
3+
4+
class ReaderView(BasePage):
5+
"""
6+
BOM for reader view
7+
"""
8+
9+
URL_TEMPLATE = ""

modules/browser_object_toolbar.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
from time import sleep
2-
31
from selenium.webdriver.support import expected_conditions as EC
42

53
from modules.page_base import BasePage
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{}

modules/page_base.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
from pypom import Page
1111
from selenium.common.exceptions import (
12-
NoAlertPresentException,
1312
NoSuchElementException,
1413
TimeoutException,
1514
)
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import pytest
2+
3+
4+
@pytest.fixture()
5+
def suite_id():
6+
return ("S2525", "Bookmarks and History")
7+
8+
9+
@pytest.fixture()
10+
def set_prefs():
11+
"""Set prefs"""
12+
return []

tests/pdf_viewer/conftest.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import pytest
2+
3+
4+
@pytest.fixture()
5+
def suite_id():
6+
return ("S65", "PDF Viewer")
7+
8+
9+
@pytest.fixture()
10+
def set_prefs():
11+
"""Set prefs"""
12+
return []

tests/reader_view/conftest.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import pytest
2+
3+
4+
@pytest.fixture()
5+
def suite_id():
6+
return ("S2126", "Reader View")
7+
8+
9+
@pytest.fixture()
10+
def set_prefs():
11+
"""Set prefs"""
12+
return []

tests/security_and_privacy/test_downloads_from_private_not_leaked.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33

44
import pytest
55
from selenium.webdriver import Firefox
6-
from selenium.webdriver.common.by import By
7-
from selenium.webdriver.common.keys import Keys
8-
from selenium.webdriver.support import expected_conditions as EC
96

107
from modules.browser_object import AboutDownloadsContextMenu, PanelUi, Toolbar
118
from modules.page_object import AboutDownloads, GenericPage

0 commit comments

Comments
 (0)