Declaring constants

Author: Hani Yacoub

tests/password_manager/test_about_logins_navigation_from_context_menu.py

@@ -10,6 +10,9 @@ def test_case():
     return "2241087"
 
 
+ABOUT_LOGINS_PAGE_TITLE = "Passwords"
+
+
 @pytest.mark.ci
 def test_about_logins_navigation_from_login_form_context_menu(driver: Firefox):
     """
@@ -19,13 +22,14 @@ def test_about_logins_navigation_from_login_form_context_menu(driver: Firefox):
     # Instantiate objects
     context_menu = ContextMenu(driver)
     tabs = TabBar(driver)
-    login = LoginAutofill(driver).open()
+    login = LoginAutofill(driver)
 
     # Access the manage passwords in context menu from the username field in the demo login form
+    login.open()
     username_field = login.get_element("username-field")
     login.context_click(username_field)
     context_menu.click_and_hide_menu("context-menu-manage-passwords")
 
     # Verify that the about:logins page is opened in a new tab
     tabs.wait_for_num_tabs(2)
-    tabs.title_contains("Passwords")
+    tabs.title_contains(ABOUT_LOGINS_PAGE_TITLE)

tests/password_manager/test_about_logins_navigation_from_hamburger_menu.py

@@ -9,6 +9,9 @@ def test_case():
     return "2241082"
 
 
+ABOUT_LOGINS_PAGE_TITLE = "Passwords"
+
+
 def test_about_logins_navigation_from_password_hamburger_menu(driver: Firefox):
     """
     C2241082 - Verify that clicking the Password option in Hamburger Menu opens about:logins page in a new tab
@@ -23,4 +26,4 @@ def test_about_logins_navigation_from_password_hamburger_menu(driver: Firefox):
 
     # Verify that the about:logins page is opened in a new tab
     tabs.wait_for_num_tabs(2)
-    tabs.title_contains("Passwords")
+    tabs.title_contains(ABOUT_LOGINS_PAGE_TITLE)

tests/password_manager/test_add_password_non_ascii_chars.py

@@ -9,6 +9,9 @@ def test_case():
     return "2241113"
 
 
+WEBSITE_ADDRESS = "mozilla.org"
+
+
 def test_add_password_non_ascii_chars(driver: Firefox):
     """
     C2241113 Add password - non-ascii characters
@@ -33,6 +36,6 @@ def test_add_password_non_ascii_chars(driver: Firefox):
     about_logins.get_element("login-list-item")
     logins = about_logins.get_elements("login-list-item")
     mozilla_login = next(
-        login for login in logins if login.get_attribute("title") == "mozilla.org"
+        login for login in logins if login.get_attribute("title") == WEBSITE_ADDRESS
     )
     assert mozilla_login

tests/password_manager/test_add_password_save_valid_data.py

@@ -10,6 +10,9 @@ def test_case():
     return "2241112"
 
 
+WEBSITE_ADDRESS = "mozilla.org"
+
+
 def test_add_password_save_valid_data(driver: Firefox):
     """
     C2241112 Verify that a password can be added and saved
@@ -34,7 +37,7 @@ def test_add_password_save_valid_data(driver: Firefox):
     about_logins.get_element("login-list-item")
     logins = about_logins.get_elements("login-list-item")
     mozilla_login = next(
-        login for login in logins if login.get_attribute("title") == "mozilla.org"
+        login for login in logins if login.get_attribute("title") == WEBSITE_ADDRESS
     )
     assert mozilla_login
 

tests/password_manager/test_add_primary_password.py

@@ -16,6 +16,7 @@ def hard_quit():
 
 
 PRIMARY_PASSWORD = "securePassword1"
+ALERT_MESSAGE = "Primary Password successfully changed."
 
 
 def test_add_primary_password(driver: Firefox):
@@ -45,5 +46,5 @@ def test_add_primary_password(driver: Firefox):
     # Check that the pop-up appears
     with driver.context(driver.CONTEXT_CHROME):
         alert = about_prefs.get_alert()
-        assert alert.text == "Primary Password successfully changed."
+        assert alert.text == ALERT_MESSAGE
         alert.accept()