exit with appropriate code

Author: sarinali

.github/workflows/smoke.yml

@@ -27,9 +27,10 @@ jobs:
           pipenv install;
       - name: Run Smoke Tests in Win
         run: |
+          set -e
           pipenv run pytest --fx-executable ./firefox/firefox -s -n 4 tests/security_and_privacy
-          mv artifacts artifacts-win
-        continue-on-error: true
+          mv artifacts artifacts-win || true
+          exit $TEST_EXIT_CODE
       - name: Upload artifacts
         if: always()
         uses: actions/upload-artifact@v4
@@ -57,9 +58,10 @@ jobs:
           pipenv install;
       - name: Run Smoke Tests in MacOS
         run: |
-          pipenv run pytest --fx-executable ./firefox/firefox -s -n 4 tests/security_and_privacy
-          mv artifacts artifacts-mac
-        continue-on-error: true
+          set -e
+          pipenv run pytest --fx-executable ./firefox/firefox -s -n 4 tests/security_and_privacy || TEST_EXIT_CODE=$?
+          mv artifacts artifacts-mac || true
+          exit $TEST_EXIT_CODE
       - name: Upload artifacts
         if: always()
         uses: actions/upload-artifact@v4

conftest.py

@@ -21,6 +21,7 @@ def screenshot_content(driver: Firefox, opt_ci: bool, test_name: str) -> None:
     """
     artifacts_loc = "artifacts" if opt_ci else ""
     current_time = str(datetime.datetime.now())
+    current_time = re.sub(r"[^\w_. -]", "_", current_time)
     filename = f"{test_name}_{current_time}_image"
     if not filename.endswith(".png"):
         filename = filename + ".png"