Merge pull request #709 from mozilla/Hani/enable-es

Hani/Enable ES and add [ES] Ebay

Author: sv-hyacoub

l10n_CM/Unified/conftest.py

@@ -106,9 +106,9 @@ def cc_site_data(live_site, region):
 @pytest.fixture
 def is_live_site(live_site, region):
     """Determine if the site is live.
-    Treat demo IT as a live site until the doorhanger bug is fixed.
+    Treat demo IT and ES as a live site until the doorhanger bug is fixed.
     """
-    return live_site != "demo" or region in {"IT"}
+    return live_site != "demo" or region in {"IT", "ES"}
 
 
 @pytest.fixture(scope="session")

l10n_CM/constants/ebay/ES/ebay_ad.json

@@ -0,0 +1,25 @@
+{
+  "url": "http://127.0.0.1:8080/ebay_ad.html",
+  "field_mapping": {
+    "country": "country",
+    "given_name": "firstName",
+    "family_name": "lastName",
+    "telephone": "phoneNumber",
+    "street_address": "addressLine1",
+    "address_level_1": "stateOrProvince",
+    "address_level_2": "city",
+    "postal_code": "postalCode"
+  },
+  "form_field": "*[id='{name}']",
+  "fields": [
+    "country",
+    "firstName",
+    "lastName",
+    "phoneNumber",
+    "addressLine1",
+    "stateOrProvince",
+    "city",
+    "postalCode"
+  ],
+  "skip_os": ["Linux"]
+}

l10n_CM/constants/ebay/ES/ebay_cc.json

@@ -0,0 +1,18 @@
+{
+  "url": "http://127.0.0.1:8080/ebay_cc.html",
+  "field_mapping": {
+    "card_number": "c995cecd-7228-4738-8b0c-8334752df865",
+    "given_name": "ea7b6d20-f825-4fda-995d-f461ec3b4e28",
+    "family_name": "07a705dd-d116-4036-abaa-494e1a20483d",
+    "expiration_date": "25921b11-f253-488b-ab18-5db93cc912ec",
+    "cvv":"38d8e85e-5fdb-498a-ba95-f4a04e38b876"
+  },
+  "form_field": "*[data-moz-autofill-inspect-id='{name}']",
+  "fields": [
+    "c995cecd-7228-4738-8b0c-8334752df865",
+    "ea7b6d20-f825-4fda-995d-f461ec3b4e28",
+    "07a705dd-d116-4036-abaa-494e1a20483d",
+    "25921b11-f253-488b-ab18-5db93cc912ec",
+    "38d8e85e-5fdb-498a-ba95-f4a04e38b876"
+  ]
+}

l10n_CM/region/ES.json

@@ -0,0 +1,9 @@
+{
+  "region": "ES",
+  "sites": [
+    "demo",
+    "ebay"
+  ],
+  "tests": [
+  ]
+}

l10n_CM/run_l10n.py

@@ -15,7 +15,7 @@
 current_dir = os.path.dirname(__file__)
 valid_flags = {"--run-headless", "-n", "--reruns", "--fx-executable", "--ci"}
 flag_with_parameter = {"-n", "--reruns"}
-valid_region = {"US", "CA", "DE", "FR", "IT", "GB", "PL"}
+valid_region = {"US", "CA", "DE", "FR", "IT", "GB", "PL", "ES"}
 valid_sites = {
     "demo",
     "amazon",

l10n_CM/sites/ebay/ES/ebay_ad.html

@@ -241,6 +241,11 @@ def verify_form_data(
                     attr_name, expected_value, auto_filled_field_value, region
                 )
 
+            # Strip whitespace before asserting
+            if expected_value is not None and auto_filled_field_value is not None:
+                expected_value = expected_value.strip()
+                auto_filled_field_value = auto_filled_field_value.strip()
+
             assert expected_value in auto_filled_field_value, (
                 f"Field '{attr_name}' ('{field_name}'): expected '{expected_value}' to be in '{auto_filled_field_value}'"
             )

l10n_CM/sites/ebay/ES/ebay_cc.html

@@ -104,7 +104,7 @@ def __init__(self):
             "Yukon": "YT",
         }
         # temporary fix until faker issue is resolved
-        self.country_local_translation = {"Germany": "Deutschland", "Italy": "Italia"}
+        self.country_local_translation = {"Germany": "Deutschland", "Italy": "Italia", "Spain": "España"}
         self.fake = None
         self.locale = None
 
@@ -277,7 +277,12 @@ def fake_autofill_data(self, country_code) -> AutofillAddressBase:
         region_attributes = ["state", "administrative_unit", "region"]
         fake, valid_code = self.create_localized_faker(country_code)
         name = fake.name()
-        given_name, family_name = name.split()
+
+        # Safely split the name
+        name_parts = name.split()
+        given_name = name_parts[0]
+        family_name = name_parts[-1] if len(name_parts) > 1 else ""
+
         organization = fake.company().replace(",", "")
         street_address = fake.street_address()
         # find correct attribute for selected locale
@@ -325,7 +330,12 @@ def fake_credit_card_data(
         """
         fake, valid_code = self.create_localized_faker(country_code)
         name = fake.name()
-        given_name, family_name = name.split()
+
+        # Safely split the name
+        name_parts = name.split()
+        given_name = name_parts[0]
+        family_name = name_parts[-1] if len(name_parts) > 1 else ""
+
         card_number = fake.credit_card_number()
         generated_credit_expiry = fake.credit_card_expire()
         expiration_month, expiration_year = generated_credit_expiry.split("/")
@@ -546,6 +556,7 @@ def normalize_regional_phone_numbers(self, phone: str, region: str) -> str:
             "DE": "49",
             "GB": "44",
             "IT": "39",
+            "ES": "34"
         }
 
         # Sub out anything that matches this regex statement with an empty string to get rid of extensions in generated phone numbers
@@ -566,7 +577,7 @@ def normalize_regional_phone_numbers(self, phone: str, region: str) -> str:
             local_number = digits[len(country_code) :]
 
         # Handle leading zero in local numbers (France & Germany)
-        if region in ["FR", "DE", "GB", "IT"] and local_number.startswith("0"):
+        if region in ["FR", "DE", "GB", "IT", "ES"] and local_number.startswith("0"):
             # Remove the leading zero
             local_number = local_number[1:]