Ben/testrail custom fields (#467)

* revert quotes on prefs obj method

* add tr endpoints for custom fields; update a test

* fix thing that bothers IDEs

* missed a str()

Author: ben-c-at-moz

modules/page_object_prefs.py

@@ -394,14 +394,14 @@ def click_popup_panel_button(self, field: str) -> BasePage:
             self.get_element("panel-popup-button", labels=[field]).click()
         return self
 
-    def select_https_only_setting(self, option_id: "HttpsOnlyStatus") -> BasePage:
+    def select_https_only_setting(self, option_id: HttpsOnlyStatus) -> BasePage:
         """
         Click the HTTPS Only option given
         """
         self.find_in_settings("HTTPS")
-        self.element_clickable(option_id)
-        self.click_on(option_id)
-        self.element_attribute_contains(option_id, "checked", "")
+        self.element_clickable(str(option_id))
+        self.click_on(str(option_id))
+        self.element_attribute_contains(str(option_id), "checked", "")
         return self
 
     def set_default_zoom_level(self, zoom_percentage: int) -> BasePage:

modules/testrail.py

@@ -160,6 +160,21 @@ def get_test_case(self, case_id):
         """Get a given Test Case"""
         return self.client.send_get(f"get_case/{case_id}")
 
+    def update_cases_in_suite(self, suite_id, case_ids, **kwargs):
+        """Given a suite and a list of test cases, update all listed
+        test cases according to keyword args"""
+        if not kwargs:
+            return None
+        return self.client.send_post(
+            f"update_cases/{suite_id}", {"case_ids": case_ids, **kwargs}
+        )
+
+    def update_test_case(self, case_id, **kwargs):
+        """Given a test case id, update according to keyword args"""
+        if not kwargs:
+            return None
+        return self.client.send_post(f"update_case/{case_id}", **kwargs)
+
     def create_test_run_on_plan_entry(
         self, plan_id, entry_id, config_ids, description=None, case_ids=None
     ):
@@ -235,6 +250,14 @@ def matching_plan_in_milestone(self, testrail_project_id, milestone_id, plan_nam
                 return self._get_full_plan(plan.get("id"))
         return None
 
+    def matching_custom_field(self, name):
+        """Given a name, return the case_field object that matches (name or label)"""
+        custom_fields = self._get_case_fields()
+        for field in custom_fields:
+            if name in field.get("name") or name in field.get("label"):
+                return field
+        return None
+
     def create_new_plan(
         self,
         testrail_project_id,
@@ -448,6 +471,9 @@ def _get_plans_in_milestone(self, testrail_project_id, milestone_id):
     def _get_full_plan(self, plan_id):
         return self.client.send_get(f"get_plan/{plan_id}")
 
+    def _get_case_fields(self):
+        return self.client.send_get("get_case_fields")
+
     def _retry_api_call(self, api_call, *args, max_retries=3, delay=5):
         """
         Retries the given API call up to max_retries times with a delay between attempts.

tests/password_manager/test_primary_password_triggered_on_about_logins_access.py

@@ -91,7 +91,7 @@ def test_primary_password_triggered_on_about_logins_access_via_hamburger_menu(
 
     # Verify that about:logins page is accessible after the primary password was entered
     driver.switch_to.window(driver.window_handles[0])
-    assert driver.current_url.startswith("about:logins")
+    about_logins.url_contains("about:logins")
 
     # Verify that the saved login is visible and accessible in the login list
     about_logins.wait.until(