Skip to content

Commit 4d61615

Browse files
sv-hyacoubHani Yacoub
andauthored
Fix test-search-suggesions (#890)
Co-authored-by: Hani Yacoub <[email protected]>
1 parent e0246be commit 4d61615

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

SELECTOR_INFO.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -663,16 +663,16 @@ Location: about:preferences#search
663663
Path to .json: modules/data/about_prefs.components.json
664664
```
665665
```
666-
Selector Name: firefox-suggest-nonsponsored
667-
Selector Data: "firefoxSuggestNonsponsored"
666+
Selector Name: firefox-suggestions
667+
Selector Data: showSearchSuggestionsFirstCheckbox
668668
Description: The Suggestions from Firefox check-box
669669
Location: about:preferences#search > Address Bar - Firefox Suggest
670670
Path to .json: modules/data/about_prefs.components.json
671671
```
672672
```
673-
Selector Name: firefox-suggest-sponsored
674-
Selector Data: "firefoxSuggestSponsored"
675-
Description: The Suggestions from sponsors check-box
673+
Selector Name: firefox-trending-suggestions
674+
Selector Data: showTrendingSuggestions
675+
Description: Trending search suggestions check-box
676676
Location: about:preferences#search > Address Bar - Firefox Suggest
677677
Path to .json: modules/data/about_prefs.components.json
678678
```

modules/data/about_prefs.components.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,13 +201,13 @@
201201
"strategy": "id",
202202
"groups": []
203203
},
204-
"firefox-suggest-nonsponsored": {
205-
"selectorData": "firefoxSuggestNonsponsored",
204+
"firefox-suggestions": {
205+
"selectorData": "showSearchSuggestionsFirstCheckbox",
206206
"strategy": "id",
207207
"groups": []
208208
},
209-
"firefox-suggest-sponsored": {
210-
"selectorData": "firefoxSuggestSponsored",
209+
"firefox-trending-suggestions": {
210+
"selectorData": "showTrendingSuggestions",
211211
"strategy": "id",
212212
"groups": []
213213
},

tests/address_bar_and_search/test_search_suggestions.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@ def test_search_suggests_enabled(driver: Firefox):
3131
if not suggestions_checkbox.is_selected():
3232
suggestions_checkbox.click()
3333

34-
nonsponsored_checkbox = prefs.get_element("firefox-suggest-nonsponsored")
34+
nonsponsored_checkbox = prefs.get_element("firefox-suggestions")
3535
assert nonsponsored_checkbox.is_selected(), (
36-
"'firefox-suggest-nonsponsored' checkbox not checked"
36+
"'firefox-suggestions' checkbox not checked"
3737
)
3838

39-
sponsored_checkbox = prefs.get_element("firefox-suggest-sponsored")
39+
sponsored_checkbox = prefs.get_element("firefox-trending-suggestions")
4040
assert sponsored_checkbox.is_selected(), (
41-
"'firefox-suggest-sponsored' checkbox not checked"
41+
"'firefox-trending-suggestions' checkbox not checked"
4242
)
4343

4444
# Check for sponsored suggestion

0 commit comments

Comments
 (0)