Skip to content

Commit 4df2437

Browse files
committed
Fix Boookmarks tests
1 parent 721bd94 commit 4df2437

File tree

5 files changed

+6
-4
lines changed

5 files changed

+6
-4
lines changed

tests/bookmarks_and_history/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ def suite_id():
99
@pytest.fixture()
1010
def prefs_list(add_to_prefs_list: dict):
1111
"""List of prefs to send to main conftest.py driver fixture"""
12-
prefs = [("browser.toolbars.bookmarks.visibility", "Always")]
12+
prefs = [("browser.toolbars.bookmarks.visibility", "always")]
1313
prefs.extend(add_to_prefs_list)
1414
return prefs
1515

tests/bookmarks_and_history/test_add_new_other_bookmark.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ def test_case():
2222

2323

2424
@pytest.mark.skipif(WIN_GHA, reason="Test unstable in Windows Github Actions")
25-
@pytest.mark.unstable(reason="https://bugzilla.mozilla.org/show_bug.cgi?id=1963396")
2625
def test_add_new_other_bookmark(driver: Firefox):
2726
"""
2827
C2084518: verify user can add another bookmark from other bookmarks

tests/bookmarks_and_history/test_delete_other_bookmarks.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ def test_case():
2222

2323

2424
@pytest.mark.skipif(WIN_GHA, reason="Test unstable in Windows Github Actions")
25-
@pytest.mark.unstable(reason="https://bugzilla.mozilla.org/show_bug.cgi?id=1963396")
2625
def test_delete_other_bookmarks(driver: Firefox):
2726
"""
2827
C2084524: Verify that a user can Delete a bookmark from 'Other Bookmarks' folder

tests/bookmarks_and_history/test_edit_bookmark_via_star_button.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ def test_case():
1515
URL_TO_SAVE = "https://monitor.mozilla.org/"
1616

1717

18-
@pytest.mark.unstable(reason="https://bugzilla.mozilla.org/show_bug.cgi?id=1963396")
1918
def test_edit_bookmark_via_star_button(driver: Firefox):
2019
"""
2120
C2084549: Verify that the user can Edit a Bookmark options from the Star-shaped button

tests/bookmarks_and_history/test_toggle_bookmarks_toolbar.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ def test_case():
99
return "2084637"
1010

1111

12+
@pytest.fixture()
13+
def add_to_prefs_list():
14+
return [("browser.toolbars.bookmarks.visibility", "never")]
15+
16+
1217
def test_toggle_bookmark_toolbar(driver: Firefox):
1318
"""
1419
C2084637: Verify that the user can Hide or Show the Bookmarks Toolbar using Keyboard shortcuts

0 commit comments

Comments
 (0)