Re-enable and fix some tests

Author: Tracy-Walker

tests/address_bar_and_search/test_default_search_provider_change_awesome_bar.py

@@ -1,10 +1,11 @@
+from platform import system
+
 import pytest
 from selenium.webdriver import Firefox
 
 from modules.browser_object import Navigation
 from modules.page_object import AboutPrefs
 
-WAIT_TIMEOUT = 10
 SEARCH_ENGINE = "DuckDuckGo"
 EXPECTED_PLACEHOLDER = f"Search with {SEARCH_ENGINE} or enter address"
 
@@ -14,7 +15,7 @@ def test_case():
     return "3028795"
 
 
-@pytest.mark.unstable(reason="Bug 1983836")
+@pytest.mark.skipif(system().lower().startswith("win"), reason="Bug 1983836")
 @pytest.mark.ci
 def test_default_search_provider_change_awesome_bar(driver: Firefox):
     """

tests/preferences/test_lang_pack_changed_from_about_prefs.py

@@ -28,7 +28,6 @@ def add_to_prefs_list():
     return [("services.sync.prefs.sync-seen.intl.accept_languages", True)]
 
 
-@pytest.mark.unstable(reason="Bug 1978598")
 def test_lang_pack_changed_from_about_prefs(driver: Firefox):
     """
     C1771617 - The language can be changed in about:preferences.

tests/security_and_privacy/test_downloads_from_private_not_leaked.py

@@ -28,7 +28,6 @@ def delete_files_regex_string():
     return r"opm.*\.pdf"
 
 
-@pytest.mark.unstable(reason="Bug 1983849")
 @pytest.mark.slow
 @pytest.mark.audio
 def test_downloads_from_private_not_leaked(driver: Firefox, delete_files, screenshot):

tests/tabs/conftest.py

@@ -9,7 +9,10 @@ def suite_id():
 @pytest.fixture()
 def prefs_list(add_to_prefs_list: dict):
     """List of prefs to send to main conftest.py driver fixture"""
-    prefs = [("browser.tabs.delayHidingAudioPlayingIconMS", "200")]
+    prefs = [
+        ("browser.tabs.delayHidingAudioPlayingIconMS", "200"),
+        ("browser.toolbars.bookmarks.visibility", "always"),
+    ]
     prefs.extend(add_to_prefs_list)
     return prefs
 

tests/bookmarks_and_history/test_open_bookmark_in_new_tab.py renamed to tests/tabs/test_open_bookmark_in_new_tab.py

@@ -32,6 +32,7 @@ def test_open_bookmark_in_new_tab(driver: Firefox):
 
     # In a new tab, right-click the bookmarked page in the toolbar and select Open in New Tab from the context menu
     tabs.new_tab_by_button()
+    tabs.wait_for_num_tabs(2)
     nav.open_bookmark_in_new_tab_via_context_menu(BOOKMARK_TITLE)
 
     # Verify that the test page is opened in a new normal tab