finish test

Author: sarinali

modules/data/about_prefs.components.json

@@ -78,7 +78,7 @@
     },
 
     "prefs-button": {
-        "selectorData": "button[label=\"{name}\"]",
+        "selectorData": "button[label='{name}']",
         "strategy": "css",
         "groups": []
     },
@@ -168,11 +168,48 @@
     },
 
     "language-set-alternatives-popup-select-language-search-more": {
-        "selectorData": "menuitem[label=\"Search for more languages…\"]",
+        "selectorData": "menuitem[label='Search for more languages…']",
         "strategy": "css",
         "groups": []
     },
 
+    "language-set-alternatives-popup-select-language-italian": {
+        "selectorData": "menuitem[label='Italiano']",
+        "strategy": "css",
+        "groups": []
+    },
+
+    "languages-shadow-root": {
+        "selectorData": "dialog[buttons='accept,cancel,help']",
+        "strategy": "css",
+        "groups": []
+    },
+
+    "language-accept-button": {
+        "selectorData": "button[dlgtype='accept']",
+        "strategy": "css",
+        "shadowParent": "languages-shadow-root",
+        "groups": []
+    },
+
+    "language-add-button": {
+        "selectorData": "add",
+        "strategy": "id",
+        "groups": []
+    },
+
+    "language-list-item": {
+        "selectorData": "locale-it",
+        "strategy": "id",
+        "groups": []
+    },
+
+    "html-root": {
+        "selectorData": "preferences-root",
+        "strategy": "id",
+        "groups": []
+    },
+
     "home-new-tabs-dropdown": {
         "selectorData": "newTabMode",
         "strategy": "id",

tests/language_packs/test_language_pack_install_preferences.py

@@ -1,43 +1,50 @@
-from time import sleep
 
 from selenium.webdriver import Firefox
 
 from modules.page_object import AboutPrefs
-from modules.util import BrowserActions, Utilities
+from modules.util import BrowserActions
 
 
 def test_language_pack_install_about_preferences(driver: Firefox):
     """
     C1549409: language packs can be installed from about:preferences and firefox is correctly localized
     """
+    # instantiate objects
     about_prefs = AboutPrefs(driver, category="general").open()
     ba = BrowserActions(driver)
-    util = Utilities()
-    about_prefs.get_element("language-set-alternatives-button").click()
+    alternative_button = about_prefs.get_element("language-set-alternatives-button")
+    alternative_button.click()
 
+    # press the alternatives button and find italian
     iframe = about_prefs.get_element("browser-popup")
     ba.switch_to_iframe_context(iframe)
     about_prefs.get_element("language-set-alternatives-popup-select-language").click()
-
     about_prefs.element_clickable(
         "language-set-alternatives-popup-select-language-search-more"
     )
-
     more_languages_option = about_prefs.get_element(
         "language-set-alternatives-popup-select-language-search-more"
     )
-
     about_prefs.double_click(more_languages_option)
-    sleep(10)
 
+    # waiting for the language install to be sucessful
     about_prefs.custom_wait(timeout=20).until(
         lambda _: about_prefs.get_element(
             "language-set-alternatives-popup-select-language"
         ).get_attribute("label")
         == "Select a language to add…"
     )
 
-    about_prefs.get_element("language-set-alternatives-popup-select-language").click()
-
-    util.write_html_content("contents", driver, False)
-    util.write_html_content("contentschrome", driver, True)
+    # activate the italian language
+    dropdown_selection = about_prefs.get_element("language-set-alternatives-popup-select-language")
+    dropdown_selection.click()
+    about_prefs.get_element("language-set-alternatives-popup-select-language-italian").click()
+    dropdown_selection.click()
+    about_prefs.get_element("language-add-button").click()
+    about_prefs.get_element("language-list-item").click()
+    about_prefs.get_element("language-accept-button").click()
+
+    # final asserts to ensure language is set
+    ba.switch_to_content_context()
+    assert about_prefs.get_element("html-root").get_attribute("lang") == "it"
+    assert alternative_button.get_attribute("label") == "Imposta alternative…"